-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3122 : Dark theme make colors of the images distorted #5141
Fix #3122 : Dark theme make colors of the images distorted #5141
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning PTAL, Thanks!
Now I am wondering that how I will test this in release version, the solution you give without that also if I test app on my Physical device the output is without any bug as mentioned in screenshot. But now the major concern is how I will test this changes with release data or release app?
[Debug] Physical device output with and without changes is same |
---|
Also app is not building with Everyone saying to update compileSdkVersion but already on 31. |
@MohitGupta121 can you check the build on Bazel to see if the attribute issue exists? Also, I think we need to check that this works on an earlier version of Android to make sure that the attributes won't cause an issue. Once these are addressed, I can check this PR with production assets. |
@BenHenning I getting same errors while building with Bazel, when using |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BenHenning @adhiamboperes PTAL, I updated PR description with Productions assests screenshots of my Physical Device and now issue is resolved. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM @MohitGupta121.
Could you please edit your PR description to explain the changes that have been made?
Thanks @adhiamboperes , sure I'll explain that. |
@adhiamboperes PR description updated. PTAL, Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @MohitGupta121, this LGTM.
Explanation
Fix #3122 : Dark theme make the colors of the images distorted
Solution: Images change their color to white when Dark mode is turned on. That's why we force disabling dark mode for Image Views prevents android from force-inverting the colors in the images.
Essential Checklist
For UI-specific PRs only
If your PR includes UI-related changes, then: