Skip to content

Commit

Permalink
Fix #3122 : Dark theme make colors of the images distorted (#5141)
Browse files Browse the repository at this point in the history
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation

Fix #3122 : Dark theme make the colors of the images distorted

Solution: Images change their color to white when Dark mode is turned
on. That's why we force disabling dark mode for Image Views prevents
android from force-inverting the colors in the images.

<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only
<!-- Delete these section if this PR does not include UI-related
changes. -->

| Before Fix | After Fix |
| ------ | ------ |
| <img
src="https://github.com/oppia/oppia-android/assets/76530270/dafd6370-c180-4ca6-bc92-0af8e528728e"
height="400" style="max-width: 100%"> | <img
src="https://github.com/oppia/oppia-android/assets/76530270/95ac7d75-3459-4acb-b682-d98a48803073"
height="400" style="max-width: 100%"> |

| Before Fix | After Fix |
| ------ | ------ |
| <img
src="https://github.com/oppia/oppia-android/assets/76530270/6d483477-dc8b-4399-b043-cb11f6295480"
height="400" style="max-width: 100%"> | <img
src="https://github.com/oppia/oppia-android/assets/76530270/3d3ab830-9cb2-4275-9e44-7f395d574ad2"
height="400" style="max-width: 100%"> |


If your PR includes UI-related changes, then:
- Add screenshots for portrait/landscape for both a tablet & phone of
the before & after UI changes
- For the screenshots above, include both English and pseudo-localized
(RTL) screenshots (see [RTL
guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines))
- Add a video showing the full UX flow with a screen reader enabled (see
[accessibility
guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide))
- Add a screenshot demonstrating that you ran affected Espresso tests
locally & that they're passing
  • Loading branch information
MohitGupta121 authored Sep 12, 2023
1 parent 5e74b84 commit b643538
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
android:importantForAccessibility="no"
app:entityId="@{viewModel.promotedStory.storyId}"
app:entityType="@{viewModel.entityType}"
android:forceDarkAllowed="false"
app:layout_constraintDimensionRatio="4:3"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/promoted_story_card.xml
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
android:importantForAccessibility="no"
app:entityId="@{viewModel.promotedStory.storyId}"
app:entityType="@{viewModel.entityType}"
android:forceDarkAllowed="false"
app:layout_constraintDimensionRatio="H, 16:9"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down
1 change: 1 addition & 0 deletions app/src/main/res/layout/recently_played_story_card.xml
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
android:importantForAccessibility="no"
app:entityId="@{viewModel.promotedStory.storyId}"
app:entityType="@{viewModel.entityType}"
android:forceDarkAllowed="false"
app:layout_constraintDimensionRatio="4:3"
app:layout_constraintEnd_toEndOf="parent"
app:layout_constraintStart_toStartOf="parent"
Expand Down

0 comments on commit b643538

Please sign in to comment.