Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4959 : Voiceover button is too small #4962

Merged
merged 2 commits into from
May 4, 2023
Merged

Fix #4959 : Voiceover button is too small #4962

merged 2 commits into from
May 4, 2023

Conversation

MohitGupta121
Copy link
Member

Explanation

Fix #4959 : Voiceover button is too small

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Before After

If your PR includes UI-related changes, then:

  • Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes
  • For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see RTL guide)
  • Add a video showing the full UX flow with a screen reader enabled (see accessibility guide)
  • Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing

Copy link
Member Author

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BenHenning PTAL, Thanks.

@BenHenning
Copy link
Member

Apologies @MohitGupta121 will need to look at this tomorrow.

@MohitGupta121
Copy link
Member Author

No problem @BenHenning, totally fine.

Copy link
Member

@BenHenning BenHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MohitGupta121. LGTM.

@oppiabot
Copy link

oppiabot bot commented May 4, 2023

Unassigning @BenHenning since they have already approved the PR.

@BenHenning BenHenning merged commit 6778805 into oppia:develop May 4, 2023
@MohitGupta121 MohitGupta121 deleted the voiceover_button_is_too_small branch May 4, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oppia's android app voiceover button is too small
2 participants