-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Oppia's android app voiceover button is too small #4959
Labels
enhancement
End user-perceivable enhancements.
Comments
@seanlip Could you please transfer it to oppia android repo |
@prafulbbandre Thanks, I moved it. |
Hi Mohit,
Thank you for increasing it a bit. However If it’s not too much to ask, I
think the size of the bubble on the right will be perfect for our users.
Thank you so much.
Best Regards,
Yigakpoa
…On Tue, 25 Apr 2023 at 15:20, MOHIT GUPTA ***@***.***> wrote:
@yigakpoa <https://github.com/yigakpoa> @seanlip
<https://github.com/seanlip> Thanks for the issue,
I little bit increase the icon size and now it's look like this:
<https://user-images.githubusercontent.com/76530270/234305749-912c5391-cd62-4966-9db5-02a3e0dc82a7.png>
@yigakpoa <https://github.com/yigakpoa> Can you please now have a look.
What's your suggestions?
—
Reply to this email directly, view it on GitHub
<#4959 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXT2HKNOG7GNVCB2FBPHA2LXC7MSJANCNFSM6AAAAAAXLB27EY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@yigakpoa I think now it's look same as bubble icon size as per screenshot. |
Thank you for your feedback.
…On Tue, 25 Apr 2023 at 16:17, MOHIT GUPTA ***@***.***> wrote:
@yigakpoa <https://github.com/yigakpoa> I think now it's look same as
bubble icon size as per screenshot.
Thanks
—
Reply to this email directly, view it on GitHub
<#4959 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXT2HKP6K2MHCBRXHBVWW7TXC7TKPANCNFSM6AAAAAAXLB27EY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
6 tasks
BenHenning
pushed a commit
that referenced
this issue
May 4, 2023
<!-- READ ME FIRST: Please fill in the explanation section below and check off every point from the Essential Checklist! --> ## Explanation Fix #4959 : Voiceover button is too small <!-- - Explain what your PR does. If this PR fixes an existing bug, please include - "Fixes #bugnum:" in the explanation so that GitHub can auto-close the issue - when this PR is merged. --> ## Essential Checklist <!-- Please tick the relevant boxes by putting an "x" in them. --> - [x] The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".) - [x] Any changes to [scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets) files have their rationale included in the PR explanation. - [x] The PR follows the [style guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide). - [x] The PR does not contain any unnecessary code changes from Android Studio ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)). - [x] The PR is made from a branch that's **not** called "develop" and is up-to-date with "develop". - [x] The PR is **assigned** to the appropriate reviewers ([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)). ## For UI-specific PRs only | Before | After | | ------ | ------ | | <img src="https://user-images.githubusercontent.com/76530270/235528862-3d0bd230-d698-4842-be16-41e7e2e0b89d.png" height="400" style="max-width: 100%"> | <img src="https://user-images.githubusercontent.com/76530270/235528841-397b5aba-21de-4bd9-847b-e5badd9a0baf.png" height="400" style="max-width: 100%"> | <!-- Delete these section if this PR does not include UI-related changes. --> If your PR includes UI-related changes, then: - Add screenshots for portrait/landscape for both a tablet & phone of the before & after UI changes - For the screenshots above, include both English and pseudo-localized (RTL) screenshots (see [RTL guide](https://github.com/oppia/oppia-android/wiki/RTL-Guidelines)) - Add a video showing the full UX flow with a screen reader enabled (see [accessibility guide](https://github.com/oppia/oppia-android/wiki/Accessibility-A11y-Guide)) - Add a screenshot demonstrating that you ran affected Espresso tests locally & that they're passing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
During my user research, I noticed that the design of the play button/icon was small and our different users kept clicking multiple times before they got it to play. This made them frustrated.
Describe the solution you'd like
The solution will be to increase the size of the "play" button by making it as big as the chat bubble on the right.
Describe alternatives you've considered
I've had to continue playing it like that and reporting it in my UX Research for consolidation.
Additional context
The text was updated successfully, but these errors were encountered: