Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #4738, #4381, #4734: Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin #4774

Merged
merged 16 commits into from
Dec 10, 2022
Merged

Fixes #4738, #4381, #4734: Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin #4774

merged 16 commits into from
Dec 10, 2022

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Nov 29, 2022 •
edited
Loading

Explanation

Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin

Fixes #4738 - Some views have very low visibility on add user profile screen in dark mode [A11y]
Fixes #4381 : Different shades of fillColor used in portrait and landscape of ic_onboarding_2.xml
Fixes #4734 : Contrast issue in show/hide password icon

Essential Checklist

  • The PR title and explanation each start with "Fix #bugnum: " (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • Any changes to scripts/assets files have their rationale included in the PR explanation.
  • The PR follows the style guide.
  • The PR does not contain any unnecessary code changes from Android Studio (reference).
  • The PR is made from a branch that's not called "develop" and is up-to-date with "develop".
  • The PR is assigned to the appropriate reviewers (reference).

For UI-specific PRs only

Onboarding Screen




Profile Chooser (Same for dark mode and light mode)

Add Admin Pin


Admin Auth


Pin Password


Add Profile


Tablet Design Recording

device-2022-12-08-183826.webm

This was referenced Nov 29, 2022
Closed
Closed
@MohitGupta121
Copy link
Member

MohitGupta121 commented Nov 29, 2022 •
edited
Loading

@rt4914 I think this PR fixed the issues #4738, #4381, #4734

@oppiabot
Copy link

oppiabot bot commented Dec 6, 2022

Hi @rt4914, it looks like some changes were requested on this pull request by @MohitGupta121. PTAL. Thanks!

@oppiabot oppiabot bot assigned rt4914 Dec 6, 2022
@rt4914 rt4914 changed the title Dark mode implementation 1 - everything before Home screen Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin Dec 8, 2022
@rt4914 rt4914 changed the title Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin Fixes #4738, #4381, #4734: Dark mode implementation - everything before Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin Dec 8, 2022
@rt4914 rt4914 marked this pull request as ready for review December 8, 2022 12:54
@rt4914 rt4914 assigned MohitGupta121 and unassigned rt4914 Dec 8, 2022
MohitGupta121
MohitGupta121 requested changes Dec 10, 2022
View reviewed changes
Copy link
Member

@MohitGupta121 MohitGupta121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rt4914 PTAL. I have one doubt.

app/src/main/res/values/component_colors.xml Show resolved Hide resolved
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 10, 2022

Onboarding icon color update

MohitGupta121
MohitGupta121 approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@MohitGupta121 MohitGupta121 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks.

@MohitGupta121 MohitGupta121 self-requested a review December 10, 2022 16:33
@rt4914 rt4914 requested review from BenHenning and seanlip December 10, 2022 16:37
@oppiabot
Copy link

oppiabot bot commented Dec 10, 2022

Assigning @seanlip, @BenHenning for code owner reviews. Thanks!

@rt4914 rt4914 removed their assignment Dec 10, 2022
@rt4914
Copy link
Contributor Author

rt4914 commented Dec 10, 2022

Hi @BenHenning @seanlip One of you will need to approve this PR. @BenHenning Feel free to review it. (FYI: Naming of some things might be a bit off right now)

seanlip
seanlip approved these changes Dec 10, 2022
View reviewed changes
Copy link
Member

@seanlip seanlip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rt4914, this looks great! LGTM.

@seanlip seanlip merged commit 8bb98a4 into develop Dec 10, 2022
@seanlip seanlip deleted the dark-mode-implementation-1 branch December 10, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MohitGupta121 MohitGupta121 MohitGupta121 approved these changes

@seanlip seanlip seanlip approved these changes

@BenHenning BenHenning Awaiting requested review from BenHenning

Assignees

@seanlip seanlip

@BenHenning BenHenning

Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rt4914 @MohitGupta121 @seanlip @BenHenning