Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Different shades of fillColor used in portrait and landscape of ic_onboarding_2.xml #4381

Closed
bhaktideshmukh opened this issue Jun 4, 2022 · 5 comments · Fixed by #4774
Closed

Different shades of fillColor used in portrait and landscape of ic_onboarding_2.xml #4381

bhaktideshmukh opened this issue Jun 4, 2022 · 5 comments · Fixed by #4774
Assignees
@rt4914
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@bhaktideshmukh
Copy link
Contributor

bhaktideshmukh commented Jun 4, 2022 •
edited by rt4914
Loading

Describe the bug
In Onboarding Screens the color codes / slide images are not consistent. The images use different color codes for different screen/mode/orientation. This is not just limited to one single slide but infact extends to all slides. Check slide-3 for reference:

Example: Download icon color

Mobile Portrait -> #00645c
Mobile Landscape -> #0d645c
Tablet -> #02655c

Dark Mode -> #3BD1C4

Expected behavior
The images should have a consistent behaviour atleast in terms of color-codes for light mode.
For now use #00645c for all types of images for dark-mode as well as night mode. If in PR the screenshots of dark-mode does not look good then in that case we might consider changing colors for dark-mode too.

In your PR please create following screenshots

  1. Mobile Portrait - Dark mode and Light mode for all 4 slides
  2. Mobile Landscape - Dark mode and Light mode for all 4 slides
  3. Tablet Portrait - Dark mode and Light mode for all 4 slides
  4. Tablet Landscape - Dark mode and Light mode for all 4 slides
@bhaktideshmukh bhaktideshmukh mentioned this issue Jun 4, 2022
Merged
6 tasks
@rt4914 rt4914 assigned rt4914 and unassigned rt4914 Jun 6, 2022
@rt4914 rt4914 added the good first issue This item is good for new contributors to make their pull request. label Jun 8, 2022
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jun 10, 2022
@MihirShirgaonkar
Copy link

hello @bhaktideshmukh
I'm intrested to contribute in this project and also im beginner to open source
can u please help me to start with?

@bhaktideshmukh
Copy link
Contributor Author

hello @bhaktideshmukh I'm intrested to contribute in this project and also im beginner to open source can u please help me to start with?

Welcome to Oppia @MihirShirgaonkar, you firstly need to sign the CLA to proceed with the contributions.
You can follow the instructions mentioned here to sign the CLA and fill out the contributor survey.

@Joaquin144
Copy link

Hi. I am interested to work on this issue.

@bhaktideshmukh
Copy link
Contributor Author

Hi. I am interested to work on this issue.

Sure go ahead, but you need to sign the CLA to proceed further if you haven't filled it yet then you can follow these instructions and if you have already filled you are good to go, I see you are already assigned.

@Joaquin144
Copy link

Yes I have signed the CLA few days before.

@Joaquin144 Joaquin144 mentioned this issue Aug 3, 2022
Closed
6 tasks
@BenHenning BenHenning added Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner and removed issue_type_infrastructure labels Sep 15, 2022
@MohitGupta121 MohitGupta121 mentioned this issue Nov 29, 2022
Merged
6 tasks
@rt4914 rt4914 self-assigned this Dec 6, 2022
seanlip pushed a commit that referenced this issue Dec 10, 2022
@rt4914
Fixes #4738, #4381, #4734: Dark mode implementation - everything befo…
8bb98a4 
…re Home screen - Onboarding, ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin (#4774)

<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->

Dark mode implementation - everything before Home screen - Onboarding,
ProfileChooser, PinPassword, AddProfile, AdminAuth, AdminPin

Fixes #4738 - Some views have very low visibility on add user profile
screen in dark mode [A11y]
Fixes #4381 : Different shades of fillColor used in portrait and
landscape of ic_onboarding_2.xml
Fixes #4734 : Contrast issue in show/hide password icon

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

## For UI-specific PRs only

### Onboarding Screen

<img
src="https://user-images.githubusercontent.com/9396084/206449915-cfa457dd-bd09-42ba-8140-17879db7a743.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206449951-3b940616-a652-45d5-bc19-a34fb957906d.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206449932-b8f94c2c-d08f-4890-b510-97ac472fbf31.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206449956-90a05426-ee4f-4fea-b4ec-e9474b454031.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206449942-caf05f2f-85b2-4817-8abe-362e1fd94ccb.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206449958-31e43303-af47-4252-a2be-3831a8507446.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206449943-bdd66537-4685-47ee-abc2-fd1d75e643f4.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206449959-24b4a5da-113f-484d-a664-e7a3f00fcd33.png"
height="400" />

### Profile Chooser (Same for dark mode and light mode)

<img
src="https://user-images.githubusercontent.com/9396084/206450271-e5df8e5e-4c7c-486f-890a-9560762e89be.png"
height="400" />

### Add Admin Pin

<img
src="https://user-images.githubusercontent.com/9396084/206450496-67e629da-6378-4a9e-8fa5-18d4aad9e581.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206450484-41bc68c0-c86e-4a16-9919-60cb753913d2.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206450501-cd8af9b4-c9ff-4e1f-9309-8209dc4b1221.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206450509-fda81199-5cef-49d3-9c3a-dc19c36fa9db.png"
height="400" />

### Admin Auth 

<img
src="https://user-images.githubusercontent.com/9396084/206450721-8b226358-eb30-4577-8242-13297949028a.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206450695-7ff2009e-9408-4f33-8762-dc861d69e1e7.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206450706-541bd34b-d69b-4bc3-aa65-ca28ee08254b.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206450713-15e46f91-ac27-4bb5-bed7-30c97fe4f6ea.png"
height="400" />

### Pin Password
<img
src="https://user-images.githubusercontent.com/9396084/206451312-c940013e-1eb0-4160-ab3f-e9734f5d0f99.png"
height="400" /> <img
src="(https://user-images.githubusercontent.com/9396084/206451325-a846e17f-99c7-48b3-915c-9734a5dff5ed.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206451320-965d86e1-19c8-42f9-aaa0-58bb8d7bf992.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206451333-a0e104f6-89ef-45a9-9e8b-d5e30b55f9b6.png"
height="400" />

### Add Profile

<img
src="https://user-images.githubusercontent.com/9396084/206451514-8338a850-1d64-451c-9cb8-6c06450dc97c.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206451536-bd9e04b2-1913-4993-9413-264707f9cc03.png"
height="400" />
<img
src="https://user-images.githubusercontent.com/9396084/206451526-378f439e-b7f6-4c89-a638-fe9e0e2118f9.png"
height="400" /> <img
src="https://user-images.githubusercontent.com/9396084/206451545-f037a1a3-abfb-4177-9844-2790e0b33f88.png"
height="400" />


### Tablet Design Recording

[device-2022-12-08-183826.webm](https://user-images.githubusercontent.com/9396084/206454707-5075dee7-59a9-47db-abe9-eb47e314465e.webm)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
7 participants
@rt4914 @BenHenning @vrajdesai78 @MihirShirgaonkar @bhaktideshmukh @Joaquin144 @Broppia