-
Notifications
You must be signed in to change notification settings - Fork 534
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix part of #3600: Add tablet UI for FAQs and Third-party Dependencies #3671
Fix part of #3600: Add tablet UI for FAQs and Third-party Dependencies #3671
Conversation
…-dependencies-list
Unassigning @rt4914 since the review is done. |
Makes sense. We will need to change content description and I think we can use |
@rt4914 The test case is now fixed - |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prayutsu. Had a few comments--PTAL.
app/src/main/java/org/oppia/android/app/help/LoadFAQListFragmentListener.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/help/LoadFAQListFragmentListener.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/help/LoadFAQListFragmentListener.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/android/app/help/LoadThirdPartyDependencyListFragmentListener.kt
Outdated
Show resolved
Hide resolved
…let-ui-for-faq-and-third-party-dependency-lists
…let-ui-for-faq-and-third-party-dependency-lists
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @prayutsu. LGTM for codeowners.
Given everyone has approved & there are no unresolved conversation threads, merging this. |
Explanation
Fixes part of #3600:
Added new UI for tablet devices for HelpActivity that shows FAQs List and Dependencies List
Mock Link - https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/dae1f41b-9551-430e-8b61-b285d6ee050b/
Checklist
Screenshots -
3 test cases failing on espresso that are only meant for phones.