Hi-fi (Tablet) for displaying third-party dependencies and their license links #3600
Assignees
Labels
Priority: Essential
This work item must be completed for its milestone.
Type: Task
A single task of work corresponding to a greater milestone. Generally corresponds to a single PR.
Z-ibt
Temporary label for Ben to keep track of issues he's triaged.
Comments
prayutsu
added
Where: Settings
Priority: Essential
Merged
8 tasks
This was referenced Aug 12, 2021
BenHenning
pushed a commit
that referenced
this issue
Aug 18, 2021
#3671) * Create ThirdPartyActivity * Fix lints * Fix actionbar issue * Add tests * Add KDocs * Add LicenseListActivity to Manifest * Fix LicenseListFragment * Add test cases * Add LicenseTextViewerFragment * Pass index to LicenseListFragment * Fix all the bugs * Fix lints * Add tests files for all activities and fragments * Fix lints * Add viewModels to BUILD.bazel * Correct path of files in exemptions file * Add suggested changes * Add suggested changes * Remove unused imports * Correct styles in xml * Optimize layouts * fix lints * Correct layout width * Add test cases for all files * Add an extra test case * Add more test cases * revert changes in ktlint_lint_check.sh * Add suggested changes * Add marquee effect * Try setting text directly from fragment. * Add code to preserve text format * Add more test cases in LicenseTextViewerFragmentTest.kt * Add label for LicenseTextViewerActivity * Add suggested changes * Use direct import for isRoot() * Add KDocs for TestApplicationComponent in Test files * Remove unused imports * Correct imports order * Fix Kdocs check * Add suggested changes * Add suggested changes * Fix failing test cases * Add interfaces to load fragments * Remove extra Kdocs and add test files to Kdoc exemptions * Add suggested changes * Replace original dependencies name with dummy text * create helplist item viewmodel * Add support for new UIs for FAQList and ThirdPartyDependencyList in tablets * Delete unwanted files * Fix nits * Add Listeners and ViewModels to BUILD.bazel * Add test cases and add test exemptions * Correct Bug * Correct import * Fix crashing after clicking item * Add suggested changes * Correct test case * Hide Back arrow by default * Correct test case * Add TAG suffix to fragment tags * Add suggested changes * Add minHeight * Add suggested changes * Add punctuation in KDoc * Correct name in test_file_exemptions.textproto
rt4914
pushed a commit
that referenced
this issue
Aug 19, 2021
…lists and texts (#3680) * Create ThirdPartyActivity * Fix lints * Fix actionbar issue * Add tests * Add KDocs * Add LicenseListActivity to Manifest * Fix LicenseListFragment * Add test cases * Add LicenseTextViewerFragment * Pass index to LicenseListFragment * Fix all the bugs * Fix lints * Add tests files for all activities and fragments * Fix lints * Add viewModels to BUILD.bazel * Correct path of files in exemptions file * Add suggested changes * Add suggested changes * Remove unused imports * Correct styles in xml * Optimize layouts * fix lints * Correct layout width * Add test cases for all files * Add an extra test case * Add more test cases * revert changes in ktlint_lint_check.sh * Add suggested changes * Add marquee effect * Try setting text directly from fragment. * Add code to preserve text format * Add more test cases in LicenseTextViewerFragmentTest.kt * Add label for LicenseTextViewerActivity * Add suggested changes * Use direct import for isRoot() * Add KDocs for TestApplicationComponent in Test files * Remove unused imports * Correct imports order * Fix Kdocs check * Add suggested changes * Add suggested changes * Fix failing test cases * Add interfaces to load fragments * Remove extra Kdocs and add test files to Kdoc exemptions * Add suggested changes * Replace original dependencies name with dummy text * create helplist item viewmodel * Add support for new UIs for FAQList and ThirdPartyDependencyList in tablets * Delete unwanted files * Fix nits * Add Listeners and ViewModels to BUILD.bazel * Add test cases and add test exemptions * Correct Bug * Correct import * Fix crashing after clicking item * Add support for Displaying LicenseList and LicenseText in Split mode in tablet devices * Add back button listener * Remove extra methods * Add suggested changes * Correct test case * Update branch * Hide Back arrow by default * Correct test case * Add test exemptions * Fix lints * Add TODO * Remove unwanted imports * Add TAG suffix to fragment tags * Fix handling of back button * Delete Unwanted fields * Make const names consistent. * Fix lint * Add white background in license_text_viewer_fragment.xml * Add suggested changes * Add content description for back button * Fix bug * Add test case * Add minHeight * Add all test cases * Add suggested changes * Add punctuation in KDoc * Correct name in test_file_exemptions.textproto * Undo unwanted changes * Add suggested changes * Add extra test case * Add suggested changes * Correct string id
BenHenning
moved this to Needs Triage
in [Team] Core Learner and Mastery flows & UI Frontend - Android
BenHenning
added
the
Z-ibt
seanlip
moved this from Needs Triage
to Done
in [Team] Core Learner and Mastery flows & UI Frontend - Android
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The dependency list and licenses list should be displayed side by side in large screen-size devices.
Mock link - https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/screen/dae1f41b-9551-430e-8b61-b285d6ee050b/
The text was updated successfully, but these errors were encountered: