Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes part of #40 & #42: Highfi Submitted answer #3187

Closed
wants to merge 1 commit into from

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented May 12, 2021

Explanation

Fixes part of #40
Fixes part of #42

This PR focuses on complete Highfi of submittted_answer_item xml file.

Currently only the outer margins have been done and inner UI is pending.

Waiting for inner UI from Chantel.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914
Copy link
Contributor Author

rt4914 commented May 12, 2021

@mschanteltc In the component guide can you add the UI (internal and not the external margins) for submitted-anwer.
You can create a page similar to this for exploration as well as question player.

Submitted-answer (white box in each screenshot) can be of following types:


Basically,

  • Submitted Answer - Text - in exploration player
  • Submitted Answer - Text - in question player (correct with tick as well as incorrect without tick)
  • Submitted Answer - List - in exploration player
  • Submitted Answer - List - in question player (correct with tick as well as incorrect without tick)

@rt4914
Copy link
Contributor Author

rt4914 commented May 19, 2021

@mschanteltc PTAL whenever possible

@anandwana001 anandwana001 added the PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged label May 25, 2021
@mschanteltc
Copy link

@mschanteltc PTAL whenever possible

Hi Rajat. I created mocks for these in mobile portrait view for your review before I create mocks for the other layouts. PTAL:

I also edited the Practice Player layout. The old one did not account for the checkmark, but the edited version does. There will always be a minimum of 32px right padding to the User's Answer. Let me know if you have any questions.

@rt4914
Copy link
Contributor Author

rt4914 commented Jun 21, 2021

Solved in #3273

@rt4914 rt4914 closed this Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR don't merge - NEEDS UPDATE Corresponds to PRs that need to be updated with the latest develop changes before they can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants