Fixes #3145: ExplorationActivityTest failing tests fixed #3147
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Fixes #3145
The two tests were failing because the
createVoiceoverMappingsFromJson
was returning map for emptycontent-ids
too.This PR updates the implementation to check if
voiceover/contentid
json is empty then do not add that asVoiceover
to the map.Screenshot
In current develop the
audio
icon is available in toolbar in all explorations. The below screenshot shows that it is no more visible for for states which do not contain audio.Checklist