Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio related tests failing on espresso #3145

Closed
rt4914 opened this issue Apr 30, 2021 · 1 comment · Fixed by #3147
Closed

Audio related tests failing on espresso #3145

rt4914 opened this issue Apr 30, 2021 · 1 comment · Fixed by #3147
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Apr 30, 2021 •
edited
Loading

testAudioWithNoVoiceover_openPrototypeExploration_checkAudioButtonIsHidden
testAudioWithNoVoiceover_openPrototypeExploration_configurationChange_checkAudioButtonIsHidden

Above mentioned tests are failing on Espresso. The implementation should be updated such that all these tests pass.

The tests are failing mostly because of commit: cb1ddc8

where we. have changed the proto/json files.
@rt4914 rt4914 added this to the Backlog milestone Apr 30, 2021
@rt4914 rt4914 added the Priority: Essential This work item must be completed for its milestone. label Apr 30, 2021
@rt4914 rt4914 modified the milestones: Backlog, Beta Apr 30, 2021
@rt4914 rt4914 self-assigned this Apr 30, 2021
@rt4914 rt4914 mentioned this issue Apr 30, 2021
Merged
8 tasks
@rt4914
Copy link
Contributor Author

rt4914 commented Apr 30, 2021

Update: For Prototype Exploration first card this value is 2 which instead should be 0.

@rt4914 rt4914 mentioned this issue Apr 30, 2021
Merged
8 tasks
rt4914 added a commit that referenced this issue May 7, 2021
@rt4914
Fixes #3145: ExplorationActivityTest failing tests fixed (#3147)
afe8882 
* Fixed error

* Updated code

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #3145: ExplorationActivityTest failing tests fixed oppia/oppia-android
2 participants
@rt4914 @BenHenning