Fix part of #2637: Added accessibilty label to the RevisionCardActivity #3009
Conversation
|
@rt4914 can you review this PR? |
| // correct string when it's read out. | ||
| assertThat(title).isEqualTo(context.getString(R.string.revision_card_activity_title)) | ||
| } | ||
| } |
There was a problem hiding this comment.
@jonathanalvares9009 EOF is missing here, please add a blank line at the end of RevisionCardActivityTest
There was a problem hiding this comment.
@jonathanalvares9009 just a small NIT, everything else looks good to me.
app/src/main/AndroidManifest.xml
Outdated
| android:theme="@style/OppiaThemeWithoutActionBar" /> | ||
| android:theme="@style/OppiaThemeWithoutActionBar" | ||
| android:label="@string/revision_card_activity_title"/> |
There was a problem hiding this comment.
This requires reformatting. Use ctrl+alt+L to reformat.
There was a problem hiding this comment.
When I try to reformat the file, it changes a lot of lines should I do or leave it.
There was a problem hiding this comment.
@jonathanalvares9009 here we only need to add a space to the last line, i.e we need to change the last line to android:label="@string/revision_card_activity_title" />
There was a problem hiding this comment.
@rt4914 will it be okay to format the entire AndroidManifest.xml here as it changes a lot of unrelated code?
jonathanalvares9009
force-pushed
the
fix-accessibilty-part1
branch
from
e77ae43 to
a261b90
Compare
|
@jonathanalvares9009 we will have to close this PR because force push tampers with the commit history. You can create a new PR for this issue |
Whenever RevisionCardActivity was clicked it used to say Oppia instead changed it to Skill page.
Fixes part of #2637
Explanation
Checklist