[A11y] Revision Card

[rt4914]

Current Output

current_revision_card.mp4

Issues Identified

• The talkback reads this screen as Oppia at start, instead it should be Skill page. Also please add test for the same. (Assigned to @jonathanalvares9009)
• After back arrow, overflow menu is selected and "What is a Fraction?" is never selected. Order should be: back-arrow, "Title" and overflow menu. (Assigned to @rt4914)

Note: To understand the above issue(s) completely, it is recommended that you setup Talkback and play with the app keeping it on and that will give you better context.

Accessibility Guide: https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide

[Prince-kushwaha]

i want to work on this issue

[rt4914]

@Prince-kushwaha I have assigned you two issues right now. So not assigning you this issue for now. Let's wait for your other PRs to get merged.

[omooooori]

@rt4914 I want to work on this issue.
If it is ok, please assign this task to me.

[rt4914]

@omooooori Thanks for showing interest. Please checkout our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

[priyanka0906]

@rt4914 may I work on this?

[omooooori]

@rt4914 I signed CLA and answered survey. So if it is ok, could you please assign this task to me.

[Akshat-gour]

@rt4914 I tested this app on physical device (Samsung C7 pro API 26) as well as on emulator(Pixel 2 API 29)
Talkback works in this order Oppia ,back-arrow, "Title" and overflow menu.

But Only Read Oppia once when we open the what is fraction under Revision Card .

Here is One More Issue when this Sound icon is tapped talkback says Unlabelled

[rt4914]

@rt4914 I want to work on this issue.
If it is ok, please assign this task to me.

@omooooori Assigned you one part of the issue.

[rt4914]

@rt4914 may I work on this?

@priyanka0906 Assigned you one part of the issue.

[rt4914]

@rt4914 I tested this app on physical device (Samsung C7 pro API 26) as well as on emulator(Pixel 2 API 29)
Talkback works in this order Oppia ,back-arrow, "Title" and overflow menu.

But Only Read Oppia once when we open the what is fraction under Revision Card .

Here is One More Issue when this Sound icon is tapped talkback says Unlabelled

@Akshat-gour Thanks for checking. What you are trying out is an exploration and this issue is related to Revision Card. You can reach revision card by following these steps: Home Screen → Select Fractions → Select Revision tab → Select first card.

[Akshat-gour]

I tried Revision also

[rt4914]

I tried Revision also

@Akshat-gour It should not read Oppia at all instead it should read only the title of the screen.

[omooooori]

@rt4914 Sorry. I have simple question.
How can we put the talkback on button ?
I would like to switch talkback on/off by on click.

[Arjupta]

@rt4914 Sorry. I have simple question.
How can we put the talkback on button ?
I would like to switch talkback on/off by on click.

@omooooori the instructions varies for different devices. You can search about enabling TalkBack in a device which you use. There are some shortcuts combination of volume and power button also( again specific for different devices)

[rt4914]

@omooooori I have just updated the assigned issue which makes it much simple. You just need a static label instead of a dynamic label.

[priyanka0906]

@rt4914 in my emulator ,talkback is not navigating to all the items, as shown in the video.

Android.Emulator.-.Pixel_4_5554.2021-02-18.00-01-46.mp4

[Akshat-gour]

@priyanka0906
Talkback Does not Automatically Read the next text.
Take a look at this to know how navigation works.
https://support.google.com/accessibility/android/answer/6006598
also
https://github.com/oppia/oppia-android/wiki/Accessibility-(A11y)-Guide

[priyanka0906]

@priyanka0906
Talkback Does not Automatically Read the next text.
Take a look at this to know how navigation works.
https://support.google.com/accessibility/android/answer/6006598

okay...thankyou

[priyanka0906]

@rt4914 I have tried android:accessibilityTraversalAfter="@id/revision_card_toolbar" but it didn't work....would you please provide any hint or something which would help me.

[rt4914]

@rt4914 I have tried android:accessibilityTraversalAfter="@id/revision_card_toolbar" but it didn't work....would you please provide any hint or something which would help me.

@priyanka0906 Suggest checking out Topic and StoryActivity toolbar and how it is implemented if we follow similar approach. It should work in Revision Card too.

[priyanka0906]

@rt4914 I have tried android:accessibilityTraversalAfter="@id/revision_card_toolbar" but it didn't work....would you please provide any hint or something which would help me.

@priyanka0906 Suggest checking out Topic and StoryActivity toolbar and how it is implemented if we follow similar approach. It should work in Revision Card too.

okay thankyou

[priyanka0906]

@rt4914 in this also title is not selected after back arrow

Android.Emulator.-.Pixel_4_5554.2021-02-20.10-55-48.mp4

[rt4914]

@priyanka0906 Thanks for providing the video. I think I will have to try to solve this and then only I can confirm the exact reason for the issue.

[priyanka0906]

@priyanka0906 Thanks for providing the video. I think I will have to try to solve this and then only I can confirm the exact reason for the issue.

okay sir

[Sparsh1212]

@rt4914 If the first part of the issue is still available, then please assign it to me. Also, please tell the static label for this screen.

[rt4914]

@Sparsh1212 First part needs confirmation on another issue from Chantel. Also, I suggest not picking these issues as you have already finished multiple issues where you are adding label. Instead try to pick something new.

[Sparsh1212]

@Sparsh1212 First part needs confirmation on another issue from Chantel. Also, I suggest not picking these issues as you have already finished multiple issues where you are adding label. Instead try to pick something new.

Sure, I have commented on other different issues as well, will start working on them as assigned.

[omooooori]

@omooooori I have just updated the assigned issue which makes it much simple. You just need a static label instead of a dynamic label.

@rt4914 I tried to resolve according to your commnet.

I think RevisionCardActivityPresenter::subscribeToSubtopicTitle() is creating sub topic title dynamically.
But if I change not to use this and set static sub topic title, all revision card sub topic title will be changed.
You mean that we should change to set static label we got from json file to revisionCardToolbarTitle.text ?

Or you mean we have to not to use LiveData to set sub topic title ?
I would like to get some advise.

Thank you in advance.

[rt4914]

@omooooori I have just updated the assigned issue which makes it much simple. You just need a static label instead of a dynamic label.

@rt4914 I tried to resolve according to your commnet.

I think RevisionCardActivityPresenter::subscribeToSubtopicTitle() is creating sub topic title dynamically.
But if I change not to use this and set static sub topic title, all revision card sub topic title will be changed.
You mean that we should change to set static label we got from json file to revisionCardToolbarTitle.text ?

Or you mean we have to not to use LiveData to set sub topic title ?
I would like to get some advise.

Thank you in advance.

@omooooori I have made this issue simpler. You can introduce a static string which reads Skill page instead of dynamic string.

[jonathanalvares9009]

@rt4914 I would like to take this issue if it's not yet complete can I get a little more context on what I'll have to do?

[jonathanalvares9009]

@rt4914 I'm trying to solve part 1 bug. I used the app with talkback. So when I click on something to raise it says oppia n then the name of the unit eg: What is a fraction?. I have to replace oppia with skill page right don't touch the header of the revision card n also write test for the implementation. Please correct if I've misunderstood the issue.

[jonathanalvares9009]

@rt4914 sir I wrote the code that says skill page instead of oppia. Do I have to write a test for the same or is the change is enough?