Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #2503 : Nit changes in PromotedStoryListViewModelTest #2559

Merged
merged 7 commits into from
Jan 25, 2021
Merged

Fix #2503 : Nit changes in PromotedStoryListViewModelTest #2559

merged 7 commits into from
Jan 25, 2021

Conversation

chrk2205
Copy link
Contributor

Explanation

Fixes #2503 Nit Code clarity in PromotedStoryListViewModelTest.kt

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@chrk2205 chrk2205 requested a review from rt4914 as a code owner January 25, 2021 11:20
@chrk2205
Copy link
Contributor Author

@rt4914 the error i mentioned in comment disappeared after the commit

rt4914
rt4914 approved these changes Jan 25, 2021
View reviewed changes
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 3faa443 into oppia:develop Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rt4914 rt4914 rt4914 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nit code clarity in PromotedStoryListViewModelTest.kt
2 participants
@chrk2205 @rt4914