Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit code clarity in PromotedStoryListViewModelTest.kt #2503

Closed
rt4914 opened this issue Jan 18, 2021 · 1 comment · Fixed by #2559
Closed

Nit code clarity in PromotedStoryListViewModelTest.kt #2503

rt4914 opened this issue Jan 18, 2021 · 1 comment · Fixed by #2559
Assignees
@chrk2205
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 18, 2021

Reference: #2246 (comment)

PromotedStoryListViewModelTest.kt needs to be updated for the suggested change.
@rt4914 rt4914 added Type: Improvement Priority: Nice-to-have This work item is nice to have for its milestone. good first issue This item is good for new contributors to make their pull request. labels Jan 18, 2021
@rt4914 rt4914 added this to the Backlog milestone Jan 18, 2021
@rt4914 rt4914 mentioned this issue Jan 18, 2021
Merged
8 tasks
@chrk2205
Copy link
Contributor

can i do this??
@rt4914

@chrk2205 chrk2205 mentioned this issue Jan 25, 2021
Merged
8 tasks
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrk2205 chrk2205

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2503 : Nit changes in PromotedStoryListViewModelTest chrk2205/oppia-android
3 participants
@rt4914 @BenHenning @chrk2205