-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #156 & #157: Continue/End Exploration player buttons- low-fi #251
Conversation
@nikitamarysolomanpvt @veena14cs @BenHenning This PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rt4914. This is an excellent start for state fragment! I'm inclined to approve the changes despite the comments, but I'm happy to discuss individual items further offline or do one more review pass if you'd like.
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/oppia/app/player/state/StateFragmentPresenter.kt
Outdated
Show resolved
Hide resolved
app/src/sharedTest/java/org/oppia/app/player/state/StateFragmentTest.kt
Outdated
Show resolved
Hide resolved
@BenHenning All conversations have been resolved and appropriate issues have been filed. Merging this PR now. |
Explanation
This fixes #156 and #157 and introduces following buttons which will be used in state:
Some dummy code has been introduced in the PR to make it functional and appropriate TODOs have been added to update them in future PRs.
Also, if Interaction Id is
MultipleChoiceInput
, then in this PR we are directly showingSubmit
button and in final implementation, theSubmit
button should not be displayed until the learner selects an answer. Similarly inTextInput
,NumericInput
, theSubmit
button is active but in final implementation it will inactive at first and will only be active if learner has typed some answer in edit-text.Reference Design Doc: https://docs.google.com/document/d/1iD4sY_hWmWRu4eC8jGoolKQ5hsqpIV5sG1NA4YB2HL4/edit?usp=sharing
This PR was earlier on #185 and #222
Checklist