Fix #156 & #157: Continue/End Exploration player buttons- low-fi #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-continue-end-button-2
6 tasks
rt4914
changed the base branch from
develop
to
introduce-exploration-progress-controller
rt4914
changed the base branch from
introduce-exploration-progress-controller
to
develop
|
@BenHenning PTAL |
tests to verify correctness. Also, added a method to facilitate notifying of DataProvider changes on the UI thread.
…-controller' into exploration-player-continue-end-button-2
rt4914
changed the base branch from
develop
to
introduce-exploration-progress-controller
rt4914
changed the base branch from
introduce-exploration-progress-controller
to
develop
…dered initialization.
…-controller' into exploration-player-continue-end-button-2
… it up to the data controller, and start adding tests.
Conflicts: domain/build.gradle domain/src/main/java/org/oppia/domain/exploration/ExplorationDataController.kt Also, migrate the data controller to the retriever.
AnswerClassificationController, and attempted to make ExplorationProgressController thread-safe. The thread-safety led to significant interface changes in the progress controller, and led to discovering some issues with the mediator live data approach to interop coroutines and LiveData. This locking mechanism will need to change since the optimal solution requires resolving #90.
…er-continue-end-button-2
with the current MediatorLiveData implementation (see #90 for more context). Fix existing progress controller tests and add a few more. All current progress controller tests are passing.
…ation support for the second test exploration (about_oppia).
This was referenced Oct 7, 2019
|
This PR has been reproduced on #222 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This fixes #156 and #157 and introduces following buttons which will be used in state:
Reference Design Doc: https://docs.google.com/document/d/1iD4sY_hWmWRu4eC8jGoolKQ5hsqpIV5sG1NA4YB2HL4/edit?usp=sharing
This PR was earlier on #178
Checklist