Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1959: Optimize admin_auth_activity.xml #2225

Merged
merged 2 commits into from
Dec 4, 2020

Conversation

FareesHussain
Copy link
Contributor

Explanation

Fixes #1959

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

Screenshots after changes

Tablet portrait Tablet Landscape
Screenshot_1607024674 Screenshot_1607024677
Mobile portrait Mobile Landscape
Screenshot_1607024958 Screenshot_1607024968

@FareesHussain
Copy link
Contributor Author

Checks show theres a error in testWorker_logEvent_withoutNetwork_enqueueRequest_verifySuccess
image
but it passes when I run it in local
image

@rt4914
Copy link
Contributor

rt4914 commented Dec 4, 2020

Checks show theres a error in testWorker_logEvent_withoutNetwork_enqueueRequest_verifySuccess
image
but it passes when I run it in local
image

Restarted the CI job. It should pass now.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FareesHussain Suggested changes.

Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 408c48e into oppia:develop Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimise code in admin_auth_activity.xml
2 participants