Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimise code in admin_auth_activity.xml #1959

Closed
MohamedMedhat1998 opened this issue Oct 8, 2020 · 3 comments · Fixed by #2225
Closed

Optimise code in admin_auth_activity.xml #1959

MohamedMedhat1998 opened this issue Oct 8, 2020 · 3 comments · Fixed by #2225
Assignees
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@MohamedMedhat1998
Copy link
Contributor

This issue is tracking the optimization work of admin_auth_activity.xml

  1. Make sure that the layout uses ConstraintLayout and there is minimal nesting of views. If this view already uses ConstraintLayout then it's fine.

  2. Make sure that all TextViews use the style from styles.xml file like Heading1, TextFieldLabel, Body, etc. whichever suits best.

While making the above changes the UI should not get affected and the end result should still be the same as before (or an optimized version of UI).

If there are multiple files with the same name, update them all.

References

Mobile Portrait: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/grid/
Mobile Landscape: https://xd.adobe.com/view/ee9e607b-dbd6-4372-48dc-b687d32af3da-98af/grid/
Tablet: https://xd.adobe.com/view/d405de00-a871-4f0f-73a0-f8acef30349b-a234/grid/
Wiki: https://github.com/oppia/oppia-android/wiki/Working-on-UI

@MohamedMedhat1998 MohamedMedhat1998 added Type: Improvement Priority: Nice-to-have This work item is nice to have for its milestone. good first issue This item is good for new contributors to make their pull request. Hacktoberfest This is a suggested Hacktoberfest issue. labels Oct 8, 2020
@MohamedMedhat1998 MohamedMedhat1998 added this to the Backlog milestone Oct 8, 2020
@bladebunny
Copy link
Contributor

bladebunny commented Oct 9, 2020

I submitted a PR that flattens the view hierarchy and uses standard (Heading2 and Subtitle1) text styles. I also made some small adjustments to the margins to be more standard. Landscape view was using a scrollview which did not appear necessary which I removed. I was not able to test completely because I wasn't sure how to get to the view through app usage. But I did verify the layouts for different sized devices in the layout editor.

See: #1963

@BenHenning
Copy link
Member

BenHenning commented Oct 9, 2020

Thanks @bladebunny. Assigning this to you.

For future issues, could you leave a message on the issue you'd like to work on so that someone else doesn't start that issue? It helps us to know who's actively working on which issues.

@FareesHussain
Copy link
Contributor

please assign this to me

rt4914 pushed a commit that referenced this issue Dec 4, 2020
* Optimize admin_auth_activity.xml

* resolving requested changes
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
5 participants