-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #2090: avoid bang bang operator in networkinterceptor #2091
Conversation
@prudhvir3ddy
|
@anandwana001 anyhow my branch will be deleted after this merge right ? |
@prudhvir3ddy The branch is from your fork, so it's up to you to delete or not. As per the naming, you can choose a descriptive naming with all small caps with |
data/src/main/java/org/oppia/android/data/backends/gae/NetworkInterceptor.kt
Outdated
Show resolved
Hide resolved
LGTM @anandwana001 do you have anything else or should i go ahead and merge this one. |
@rt4914 I will defer to Rajat. Please also fill the contributor survey to take contributions further. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. @anandwana001 You can make a note of this as you are the onboarding mentor.
@rt4914 Thanks |
Explanation
removed bang bang operator which may null pointer exception though current code got null check but this is just a better way of coding and making use of kotlin higher order function . fixes #2090
Checklist