Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use higher order functions for null check in NetworkInterceptor #2090

Closed
prudhvir3ddy opened this issue Nov 6, 2020 · 1 comment · Fixed by #2091
Closed

use higher order functions for null check in NetworkInterceptor #2090

prudhvir3ddy opened this issue Nov 6, 2020 · 1 comment · Fixed by #2091
Assignees
@prudhvir3ddy
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@prudhvir3ddy
Copy link
Contributor

current code uses bang bang operator though with null check

Screenshot 2020-11-06 at 8 50 39 AM

we can use let higher order function to avoid this.
@prudhvir3ddy prudhvir3ddy mentioned this issue Nov 6, 2020
Merged
8 tasks
@anandwana001
Copy link
Contributor

anandwana001 commented Nov 6, 2020 •
edited
Loading

@prudhvir3ddy Thanks for showing interest in contributing to Oppia.
As you had already filled the CLA, could you also please complete the other points in our onboarding instruction.
https://github.com/oppia/oppia-android/wiki#onboarding-instructions

As per this issue, We recommend choosing either bug report or feature request when filing a new issue, there's a template to follow.

It will be always easy to discuss things in our Gitter channel first before creating an issue which is more inclined towards a feature request or some formating, this helps to keep the team in sync and contributors and core team members can discuss over either we need any modification or not.

Gitter channel - https://gitter.im/oppia/oppia-android

@rt4914 rt4914 added this to the Backlog milestone Nov 6, 2020
@rt4914 rt4914 added good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Status: In implementation labels Nov 6, 2020
rt4914 pushed a commit that referenced this issue Nov 8, 2020
@prudhvir3ddy
Fix #2090: avoid bang bang operator in networkinterceptor (#2091)
3b3748f 
* removed bang bang operator in NetworkInterceptor.kt and used let for null check

* renamed it to responseBody for higher order function
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prudhvir3ddy prudhvir3ddy

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #2090: avoid bang bang operator in networkinterceptor prudhvir3ddy/oppia-android
4 participants
@rt4914 @BenHenning @prudhvir3ddy @anandwana001