Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix part of #1870: Fix ProfileRenameActivityTest for Robolectric #2067

Merged

Conversation

anandwana001
Copy link
Contributor

Explanation

Fix part of #1870
Fixed ProfileRenameActivityTest
Added a test case in ProfileEditActivityTest, it should be this particular file as Robolectric not support e2e tests. Keeping the test in their particular file and testing there only will be a good practice.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@anandwana001 anandwana001 changed the title Fix #1870: Fix ProfileRenameActivityTest for Robolectric Fix part of #1870: Fix ProfileRenameActivityTest for Robolectric Oct 31, 2020
@anandwana001 anandwana001 requested a review from rt4914 October 31, 2020 11:43
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the branch after which we can merge this PR.

Thanks @anandwana001

@rt4914 rt4914 assigned anandwana001 and unassigned rt4914 Nov 3, 2020
Copy link
Contributor

@rt4914 rt4914 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@rt4914 rt4914 merged commit 66c1735 into oppia:develop Nov 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants