Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix app module tests in settings.profile for Robolectric #1870

Closed
2 tasks done
Sarthak2601 opened this issue Sep 23, 2020 · 5 comments
Closed
2 tasks done

Fix app module tests in settings.profile for Robolectric #1870

Sarthak2601 opened this issue Sep 23, 2020 · 5 comments
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@Sarthak2601
Copy link
Contributor

Sarthak2601 commented Sep 23, 2020 •
edited by anandwana001
Loading

Currently, the app module test cases in the settings.profile file are passing on Espresso but they should also pass on Robolectric. Fix these below mentioned files to make sure that the tests pass on Robolectric.

You can run robolectric tests by following these steps: https://github.com/oppia/oppia-android/wiki/Oppia-Android-Testing#running-roboelectric-tests

Fixing test cases will need to introduce TextApplicationComponent. This can be seen here.
@Sarthak2601 Sarthak2601 added Priority: Essential This work item must be completed for its milestone. SLoP 2020 labels Sep 23, 2020
@Sarthak2601 Sarthak2601 added this to the Beta milestone Sep 23, 2020
@rt4914 rt4914 mentioned this issue Sep 24, 2020
Closed
24 tasks
@alokbharti
Copy link
Contributor

Assigning this to myself as I had already made a PR (#1925 ) related to ProfileEditViewModel and it requires fixing ProfileEditActivityTest

@alokbharti alokbharti self-assigned this Oct 16, 2020
@rt4914
Copy link
Contributor

rt4914 commented Oct 17, 2020

Assigning this to myself as I had already made a PR (#1925 ) related to ProfileEditViewModel and it requires fixing ProfileEditActivityTest

Thanks @alokbharti

@alokbharti alokbharti mentioned this issue Oct 22, 2020
Merged
8 tasks
@anandwana001
Copy link
Contributor

@alokbharti Unassigning you as you are solving only a part of it, not the complete issue. This blocks the issue to be taken for other contributors.

@anandwana001 anandwana001 mentioned this issue Oct 31, 2020
Merged
8 tasks
rt4914 pushed a commit that referenced this issue Nov 4, 2020
@anandwana001
Fix part of #1870: Fix ProfileRenameActivityTest for Robolectric (#2067)
66c1735 
* Fix ProfileRenameActivityTest for Robolectric

* added top level comment
@alokbharti
Copy link
Contributor

Test cases in ProfileEditActivityTest class are fixed. @Sarthak2601 please mark it complete and I think this issue can be closed now.

@anandwana001
Copy link
Contributor

closing this issue as it is fixed in multiple PR's

@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rt4914 @BenHenning @anandwana001 @alokbharti @Sarthak2601