Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1508: Changed string type to int for subtopic-id #1510

Merged
merged 5 commits into from
Jul 23, 2020
Merged

Fix #1508: Changed string type to int for subtopic-id #1510

merged 5 commits into from
Jul 23, 2020

Conversation

rt4914
Copy link
Contributor

@rt4914 rt4914 commented Jul 23, 2020

Explanation

Fixes #1508

This PR changes the subtopic type from string to int. This is needed because if you check the subtopic json files, the id of a subtopic is of integer type. So I have updated the proto, domain and app layer to fix this.

Also, for now this PR does not fix this type for EventLogger as it might affect Sarthak's PR and therefore I will confirm with this.

Checklist

  • The PR title starts with "Fix #bugnum: ", followed by a short, clear summary of the changes. (If this PR fixes part of an issue, prefix the title with "Fix part of #bugnum: ...".)
  • The PR explanation includes the words "Fixes #bugnum: ..." (or "Fixes part of #bugnum" if the PR only partially fixes an issue).
  • The PR follows the style guide.
  • The PR does not contain any unnecessary auto-generated code from Android Studio.
  • The PR is made from a branch that's not called "develop".
  • The PR is made from a branch that is up-to-date with "develop".
  • The PR's branch is based on "develop" and not on any other branch.
  • The PR is assigned to an appropriate reviewer in both the Assignees and the Reviewers sections.

@rt4914 rt4914 requested a review from anandwana001 July 23, 2020 02:30
anandwana001
anandwana001 approved these changes Jul 23, 2020
View reviewed changes
Copy link
Contributor

@anandwana001 anandwana001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.
Just added a few points I thought while reviewing.

app/src/main/java/org/oppia/app/topic/practice/TopicPracticeFragment.kt Outdated Show resolved Hide resolved
app/src/main/java/org/oppia/app/topic/practice/TopicPracticeFragmentPresenter.kt Show resolved Hide resolved
app/src/main/java/org/oppia/app/topic/revisioncard/RevisionCardActivity.kt Outdated Show resolved Hide resolved
@anandwana001 anandwana001 assigned rt4914 and unassigned anandwana001 Jul 23, 2020
@rt4914 rt4914 merged commit ddcf9e9 into develop Jul 23, 2020
@rt4914 rt4914 deleted the change-subtopic-id-type branch July 23, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sarthak2601 Sarthak2601 Sarthak2601 left review comments

@anandwana001 anandwana001 anandwana001 approved these changes

Assignees

@rt4914 rt4914

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change subtopic-id type from string to int in proto file.
3 participants
@rt4914 @anandwana001 @Sarthak2601