Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change subtopic-id type from string to int in proto file. #1508

Closed
rt4914 opened this issue Jul 22, 2020 · 0 comments · Fixed by #1510
Closed

Change subtopic-id type from string to int in proto file. #1508

rt4914 opened this issue Jul 22, 2020 · 0 comments · Fixed by #1510
Assignees
@rt4914
Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.4 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jul 22, 2020

Json file contains subtopic-ids as int but proto contains them as string, so update the proto and all other layers to make sure that we pass subtopic-id as int.
@rt4914 rt4914 self-assigned this Jul 22, 2020
@rt4914 rt4914 added Priority: Essential This work item must be completed for its milestone. Status: Not started labels Jul 22, 2020
@rt4914 rt4914 added this to the Alpha milestone Jul 22, 2020
@rt4914 rt4914 mentioned this issue Jul 23, 2020
Merged
8 tasks
rt4914 added a commit that referenced this issue Jul 23, 2020
@rt4914
Fix #1508: Changed string type to int for subtopic-id (#1510)
ddcf9e9 
* Changed string type to int for subtopic-id

* Nit changes

* Nit changes

* Updated test case

Co-authored-by: Rajat Talesra <[email protected]>
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rt4914 rt4914

Labels
Priority: Essential This work item must be completed for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.4 Release Blockers (Alpha MR1)
Development

Successfully merging a pull request may close this issue.

Fix #1508: Changed string type to int for subtopic-id oppia/oppia-android
2 participants
@rt4914 @BenHenning