[Feature Request]: Remove the EnableContinueButtonAnimation Feature Flag

[kkmurerwa]

Is your feature request related to a problem? Please describe.

Since the EnableContinueButtonAnimation has been officially rolled out, the related feature flag can now be removed.

Describe the solution you'd like

I would like to have the EnableContinueButtonAnimation feature flag removed from the FeatureFlagConstants file since the feature it was gating has officially been released and is stable. Any of its related constants and dagger module declarations should also be removed. Lastly, I would like the if statements surrounding any functionality that is gated using this feature flag to be removed as well.

Describe alternatives you've considered

No response

Additional context

No response

[deonwaju]

Hello, Is there anyone on this? I would like to take this up.

[kkmurerwa]

Hi @deonwaju. @adhiamboperes should first triage this issue since I have just created it before it can be assigned. It also requires modifications on code that hasn't been merged yet and it is currently undoable until PR #5203 is merged.

[deonwaju]

Ok thanks, any other first issues I can take up pending the time? @kkmurerwa

[kkmurerwa]

@adhiamboperes will recommend a few first issues you can look at as she's triaging this issue. In the meantime, you can also go to this link to check out some of the first issues that haven't been assigned to someone yet.

[deonwaju]

Thanks

[kmanikanta335]

can i work on this issue ?

[adhiamboperes]

@deonwaju can you please give an overview of how you plan to solve the issue, including the files that need to be changed.

[adhiamboperes]

can i work on this issue ?

If you'd like to work on an issue please make sure you describe your proposed solution on the issue and we will then assign it to you.

[deonwaju]

Hello, @adhiamboperes

Here is my proposed solution and files to be changed

1. Go to PlatformParameterConstants.kt file and remove from line 173 to 182 and remove unused imports.

2. Go to ContinueButtonView.kt file, remove from line 28 and 29 the declaration of the lateinit var enableContinueButtonAnimation: PlatformParameterValue and the field injection
   and remove unused imports

3. In the same ContinueButtonView.kt file, remove the "if statement" logic on line 122 and the enclosing brackets.

4. Finally, Go to the following files belowand remove occurences of @provide and @EnableContinueButtonAnimation and the provide function instances in all the module declarations. Also remove the unused imports from each file
   TestParamenterModule.kt, PlatformParameterModule.kt, PlatformParameterAlphaModule.kt,
   PlatformParameterAlphaKenyaModule.kt

   Example of lines to look out for and remove from the above files are in the screenshot below

5. (A) Remove declaration of TestPlatformParameterModule.forceEnableContinueButtonAnimation() from all test functions namely:
   testContinueInteractionAnim_openPrototypeExp_checkContinueButtonAnimatesAfter45Seconds(), testConIntAnim_openProtExp_orientLandscapeAfter30Sec_checkAnimHasNotStarted(), testConIntAnim_openProtExp_orientLandAfter30Sec_checkAnimStartsIn15SecAfterOrientChange(), testContNavBtnAnim_openMathExp_checkContNavBtnAnimatesAfter45Seconds(), testContNavBtnAnim_openMathExp_playThroughSecondState_checkContBtnDoesNotAnimateAfter45Sec(), testConIntAnim_openFractions_expId1_checkButtonDoesNotAnimate()
   in StateFragmentLocalTest.kt file

(B) Remove function declaration TestPlatformParameterModule.forceEnableContinueButtonAnimation(false) from setup() function
in StateFragmentTest.kt


(C) Remove function declaration TestPlatformParameterModule.forceEnableContinueButtonAnimation(false) from setup() function
in ExploreActivityTest.kt

Please look through if the proposed solution meet the project requirements, so that I can make a PR. Thanks
Kind regards.
@adhiamboperes updated

[adhiamboperes]

Thanks @deonwaju, I have assigned the issue to you.