Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature Request]: Remove the EnableLanguageSelectionUi Feature Flag #5225

Closed
kkmurerwa opened this issue Nov 14, 2023 · 6 comments · Fixed by #5239
Closed

[Feature Request]: Remove the EnableLanguageSelectionUi Feature Flag #5225

kkmurerwa opened this issue Nov 14, 2023 · 6 comments · Fixed by #5239
Assignees
@kmanikanta335
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.

Comments

@kkmurerwa
Copy link
Collaborator

kkmurerwa commented Nov 14, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.

Since the EnableLanguageSelectionUi has been officially rolled out, the related feature flag can now be removed.

Describe the solution you'd like

I would like to have the EnableLanguageSelectionUi feature flag removed from the FeatureFlagConstants file since the feature it was gating has officially been released and is stable. Any of its related constants and dagger module declarations should also be removed. Lastly, I would like the if statements surrounding any functionality that is gated using this feature flag to be removed as well.

Describe alternatives you've considered

No response

Additional context

No response
@kkmurerwa kkmurerwa added enhancement End user-perceivable enhancements. triage needed good first issue This item is good for new contributors to make their pull request. labels Nov 14, 2023
@adhiamboperes adhiamboperes removed their assignment Nov 14, 2023
@adhiamboperes adhiamboperes added Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. and removed triage needed labels Nov 14, 2023
@kmanikanta335
Copy link
Contributor

can i work on this issue ?

@adhiamboperes
Copy link
Collaborator

@kmanikanta335 can you please give an overview of how you plan to solve the issue, including the files that need to be changed.

@kmanikanta335
Copy link
Contributor

kmanikanta335 commented Nov 15, 2023 •
edited
Loading

@adhiamboperes Here is the overview

  1. first file OptionControlsViewModel.kt.kt I would to like remove
    i) the imports of EnableLanguageSelectionUi
    ii) line 35
    iii) the if condition in line 115
  2. second file sharedTestOptionsFragmentList.kt I would like to remove
    i) lines 149 and 373
  3. third file OptionsFragemgtTest.kt i would like to remove
    i) lines 116 and 174

@adhiamboperes
Copy link
Collaborator

@kmanikanta335, your solution describes removing usages of this platform param, but you must also remove its declaration. Please see #5226 (comment) on removing the parameter from the constants file and the dagger modules.

@adhiamboperes adhiamboperes added Work: Low Solution is clear and broken into good-first-issue-sized chunks. and removed Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. labels Nov 15, 2023
@adhiamboperes
Copy link
Collaborator

@kmanikanta335, are you still putting up a PR for this issue?

@kmanikanta335 kmanikanta335 mentioned this issue Nov 21, 2023
Merged
5 tasks
@kmanikanta335
Copy link
Contributor

@adhiamboperes yes i have made a PR please review it

kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Nov 27, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
92fbc8d
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Nov 28, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
408e594
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Nov 29, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
b4fbfcf
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Nov 29, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
232bfed
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Dec 4, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
359b7ca
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Dec 5, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
6f01b59
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Dec 10, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
00616d5
kmanikanta335 added a commit to kmanikanta335/oppia-android that referenced this issue Dec 11, 2023
@kmanikanta335
Fix oppia#5225: Remove the EnableLanguageSelectionUi Feature Flag
9a86546
adhiamboperes pushed a commit that referenced this issue Jan 3, 2024
@kmanikanta335
Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag (#5239)
082c1b6 
<!-- READ ME FIRST: Please fill in the explanation section below and
check off every point from the Essential Checklist! -->
## Explanation
<!--
- Explain what your PR does. If this PR fixes an existing bug, please
include
- "Fixes #bugnum:" in the explanation so that GitHub can auto-close the
issue
  - when this PR is merged.
  -->
Fix #5225

Remove declarations and usages of the EnableLanguageSelectionUi
PlatformParameter.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- The PR title and explanation each start with "Fix #bugnum: " (If this
PR fixes part of an issue, prefix the title with "Fix part of #bugnum:
...".)
- [ ] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [ ] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [ ] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [ ] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [ ] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).

-
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmanikanta335 kmanikanta335

Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Work: Low Solution is clear and broken into good-first-issue-sized chunks.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #5225: Remove the EnableLanguageSelectionUi Feature Flag kmanikanta335/oppia-android
3 participants
@kkmurerwa @adhiamboperes @kmanikanta335