Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continue button is not aligned properly when reading text size is extra large #4361

Closed
KolliAnitha opened this issue May 16, 2022 · 17 comments · Fixed by #4385
Closed

Continue button is not aligned properly when reading text size is extra large #4361

KolliAnitha opened this issue May 16, 2022 · 17 comments · Fixed by #4385
Assignees
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@KolliAnitha
Copy link

KolliAnitha commented May 16, 2022

Describe the bug
Continue button is not aligned properly when reading text size is extra large

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'Navigation menu'- Select Options
  2. Click on 'Reading text size'- Change to Extra Large
  3. Open any exploration
  4. Scroll down to click on Continue

Expected behavior
Continue button should be aligned properly

Screenshot_2022-05-16-16-08-24-65_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment:
Device name: One plus Nord2 5G
Android version : Android 11
App version: 0.7-alpha-6c08d882d3

@saudAnwar786
Copy link

@KolliAnitha I can do this by changin text size

@BenHenning BenHenning added Found-in: 0.7-alpha (Alpha MR4) good first issue This item is good for new contributors to make their pull request. labels May 18, 2022
@BenHenning
Copy link
Member

Thanks for showing interest @saudAnwar786. I suggest addressing #4352 before tackling a second issue, though I think this is a good candidate.

Please note that this isn't quite as simple as changing text size. We want components like buttons to have consistent sizes throughout the app, so it's instead necessary to figure out how ensure the button is large enough to fit the text rather than shrinking the text.

@BenHenning
Copy link
Member

For searching context, this issue was found in 0.7-alpha (MR4).

@Chandra-Sekhar-Bala
Copy link
Contributor

Hey @BenHenning can I work on this?

@BenHenning
Copy link
Member

Hi @Chandra-Sekhar-Bala! Thanks for showing interest in Oppia!

I see that you're a first-time contributor. I suggest heading over to our onboarding wiki page for instructions on how to get started with contributing on Oppia. Once done, this issue is definitely available to be worked on.

@Chandra-Sekhar-Bala
Copy link
Contributor

Thanks for the reference @BenHenning. Successfully submitted CLA from and Oppia contributor survey form and read all docs.
Think I'm ready to get started with this issue. I'll be needing more help in future steps, as I am just a beginner at open source.

@BenHenning
Copy link
Member

Sounds good @Chandra-Sekhar-Bala. In that case, I suggest mentioning that you'd like to work on this issue to your onboarding mentor once they reach out to you. Welcome to Oppia. :)

@Chandra-Sekhar-Bala
Copy link
Contributor

@BenHenning , Okay will do that and also thanks for that welcome too ☺️

@Chandra-Sekhar-Bala
Copy link
Contributor

Hey @yash10019coder , I'd like to start with this one 🦾

@yash10019coder
Copy link
Contributor

Assigned @Chandra-Sekhar-Bala thanks

@Chandra-Sekhar-Bala
Copy link
Contributor

I think the issue is solved, what should I do now ?

@yash10019coder
Copy link
Contributor

@Chandra-Sekhar-Bala you can now make a pull request by following this guide.

@BenHenning
Copy link
Member

BenHenning commented Jun 30, 2022

Sorry, this is actually being worked on by @Ryggs. I forgot to assign it before.

@pratyaksh1610
Copy link
Contributor

I would like to work on this issue. @BenHenning

@pratyaksh1610
Copy link
Contributor

I am unable to find good first issue that i can resolve. Can u help me out @BenHenning

@BenHenning
Copy link
Member

Hi @pratyaksh1610. You can find available starter issues here. That being said, it looks like this is your first time contributing to the codebase, You should head over to the onboarding instructions on the wiki so that you can get started with the steps to be onboarded. Part of that process includes finding a viable starter issue.

@pratyaksh1610
Copy link
Contributor

pratyaksh1610 commented Jul 7, 2022

Thanks for the reference @BenHenning. Successfully submitted CLA from and Oppia contributor survey form and read all docs.
Think I'm ready to get started with open source.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
8 participants