Fix #4361: Continue button is not aligned properly when reading text …

…size in extra large (#4385) * fixed_continue_action_button * fixed_continue_action_button * add layout width * removed continue_submit_button_width dimens
oppia · Aug 13, 2022 · a55c8b2 · a55c8b2
1 parent db57738
commit a55c8b2
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/app/src/main/res/layout/continue_interaction_item.xml b/app/src/main/res/layout/continue_interaction_item.xml
@@ -49,7 +49,7 @@
     <Button
       android:id="@+id/continue_button"
       style="@style/StateButtonActive"
-      android:maxWidth="@dimen/continue_submit_button_width"
+      android:layout_width="wrap_content"
       android:onClick="@{(v) -> viewModel.handleButtonClicked()}"
       android:text="@string/state_continue_button"
       app:layout_constraintBottom_toBottomOf="parent"

diff --git a/app/src/main/res/layout/continue_navigation_button_item.xml b/app/src/main/res/layout/continue_navigation_button_item.xml
@@ -49,7 +49,7 @@
     <Button
       android:id="@+id/continue_navigation_button"
       style="@style/StateButtonActive"
-      android:maxWidth="@dimen/continue_submit_button_width"
+      android:layout_width="wrap_content"
       android:onClick="@{(v) -> buttonViewModel.continueNavigationButtonListener.onContinueButtonClicked()}"
       android:text="@string/state_continue_button"
       app:layout_constraintBottom_toBottomOf="parent"

diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml
@@ -377,7 +377,6 @@
   <dimen name="general_button_item_split_view_margin_top_left">20dp</dimen>
   <dimen name="general_button_item_split_view_margin_top_right">68dp</dimen>
   <dimen name="general_button_item_margin_top">20dp</dimen>
-  <dimen name="continue_submit_button_width">88dp</dimen>
 
   <!-- General Button Item: Exploration Split View -->
   <dimen name="general_button_item_exploration_split_view_margin_start">44dp</dimen>