Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spelling mistake is seen while setting up pin in 'Enter a New Pin' dialog box #4352

Closed
KolliAnitha opened this issue May 10, 2022 · 8 comments · Fixed by #4487
Closed

Spelling mistake is seen while setting up pin in 'Enter a New Pin' dialog box #4352

KolliAnitha opened this issue May 10, 2022 · 8 comments · Fixed by #4487
Assignees
@pratyaksh1610
Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@KolliAnitha
Copy link

KolliAnitha commented May 10, 2022 •
edited
Loading

Describe the bug
Spelling mistake is seen while setting up pin in 'Enter a New Pin' dialog box

To Reproduce
Steps to reproduce the behavior:

  1. Select a learner to login
  2. Click on 'I forgot my PIN'
  3. Enter admin pin
  4. Enter a new pin dialog box will be seen
  5. Verify the dialog box

Expected behavior
This PIN will be new PIN and will be required when signing in. should be seen

Actual Result:
This PIN wil be new PIN and will be required when signing in. is seen

Screenshot_2022-04-29-12-28-21-34_943a62cb4c6fb83e010e1c2e82766a17.jpg

Environment
Device name: One plus Nord2 5G
Android version : Android 11
App version : 0.7-alpha-d1b2827517
@saudAnwar786
Copy link

hey ! I can solve this issue very quickly

@rishidyno
Copy link
Contributor

Hey, @saudAnwar786 I have assigned this to you.

@saudAnwar786
Copy link

saudAnwar786 commented May 17, 2022 via email

@BenHenning BenHenning mentioned this issue May 18, 2022
Closed
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels May 31, 2022
@BenHenning
Copy link
Member

For searching context, this issue was found in 0.7-alpha (MR4).

@BenHenning BenHenning added this to the Beta MR2 milestone Jun 11, 2022
@pratyaksh1610
Copy link
Contributor

pratyaksh1610 commented Jul 7, 2022 •
edited
Loading

@BenHenning Pls assign this issue to me , if it is not assigned yet, I would love to contribute.

@pratyaksh1610
Copy link
Contributor

@rishidyno I have resolved this issue. Pls assign this issue to me.

@vrajdesai78
Copy link
Contributor

@saudAnwar786 unassiging you from this issue due to inactivity from last 2 months.

@pratyaksh1610 pratyaksh1610 mentioned this issue Jul 8, 2022
Closed
6 tasks
@pratyaksh1610
Copy link
Contributor

@vrajdesai78 I have made a PR.

@pratyaksh1610 pratyaksh1610 mentioned this issue Aug 3, 2022
Merged
6 tasks
@BenHenning BenHenning added good first issue This item is good for new contributors to make their pull request. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_learner labels Sep 15, 2022
@BenHenning BenHenning removed this from the Beta MR2 milestone Sep 16, 2022
@BenHenning BenHenning moved this from Needs Triage to In Progress: Being implemented in [Team] Core Learner and Mastery flows & UI Frontend - Android Sep 20, 2022
BenHenning pushed a commit that referenced this issue Oct 5, 2022
@pratyaksh1610
Fix #4352: Spelling mistake when setting up pin in "Enter a New Pin" …
fc6c881 
…dialog box (#4487)

* added test and localised string

* changed test name

* fixed lint checks

* fixed lint checks

* changed test name

* updated test

* fixed CI checks

* fixed lint check

* fix CI checks
Repository owner moved this from In Progress: Being implemented to Done in [Team] Core Learner and Mastery flows & UI Frontend - Android Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pratyaksh1610 pratyaksh1610

Labels
good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
7 participants
@BenHenning @vrajdesai78 @pratyaksh1610 @rishidyno @KolliAnitha @saudAnwar786 @Broppia