Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nit code change in HomeActivityTest.kt #2504

Closed
rt4914 opened this issue Jan 18, 2021 · 6 comments · Fixed by #2586
Closed

Nit code change in HomeActivityTest.kt #2504

rt4914 opened this issue Jan 18, 2021 · 6 comments · Fixed by #2586
Assignees
@yurilev
Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@rt4914
Copy link
Contributor

rt4914 commented Jan 18, 2021

HomeActivityTest.kt needs to be updated as per this comment
#2246 (comment)
@rt4914 rt4914 added Type: Improvement Priority: Nice-to-have This work item is nice to have for its milestone. good first issue This item is good for new contributors to make their pull request. labels Jan 18, 2021
@rt4914 rt4914 added this to the Backlog milestone Jan 18, 2021
@rt4914 rt4914 mentioned this issue Jan 18, 2021
Merged
8 tasks
@yurilev
Copy link
Contributor

yurilev commented Jan 29, 2021

Can I work on this issue?

@FareesHussain
Copy link
Contributor

@yurilev Thanks for showing interest in oppia. Please check out our wiki first. This will help you in setting up the project and once you sign the CLA and fill the survey form we can assign you issues to work on.

@yurilev
Copy link
Contributor

yurilev commented Jan 29, 2021

Hi Farees, I already did all that.

@yurilev
Copy link
Contributor

yurilev commented Jan 29, 2021 •
edited
Loading

Which tablet image is recommended when running Espresso tests in an emulator?

@yurilev
Copy link
Contributor

yurilev commented Jan 29, 2021

The nit was for testHomeActivity_allTopicsCompleted_displaysAllTopicCards(), which appears to be broken on tablets, expecting the wrong number of columns. Similar tests in the same file have 4 versions, for mobile/tablet and portrait/landscape.

May I fix the test and make related improvements as part of this, or should I file a separate issue?

This was referenced Jan 30, 2021
Merged
Closed
@yurilev
Copy link
Contributor

yurilev commented Jan 30, 2021

The nit was for testHomeActivity_allTopicsCompleted_displaysAllTopicCards(), which appears to be broken on tablets, expecting the wrong number of columns. Similar tests in the same file have 4 versions, for mobile/tablet and portrait/landscape.

May I fix the test and make related improvements as part of this, or should I file a separate issue?

Filed #2587.

rt4914 pushed a commit that referenced this issue Feb 3, 2021
@yurilev
Fix #2504: Address nit for HomeActivityTest to use verifyHomeRecycler…
bc724e4 
…ViewHasGridColumnCount() helper (#2586)

* Use the `verifyHomeRecyclerViewHasGridColumnCount` helper in one applicable test where it isn't used yet.

* Fix typo.

* Remove incorrect/confusing comment.

What is actually being verified is the number of columns. In this instance, it's true that there are also two rows, but none of the similar tests check the number of rows, so I assume the reference was unintentional.

* Empty commit to retrigger CI tests.
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yurilev yurilev

Labels
good first issue This item is good for new contributors to make their pull request. Priority: Nice-to-have This work item is nice to have for its milestone. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
4 participants
@yurilev @rt4914 @BenHenning @FareesHussain