Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test testHomeActivity_allTopicsCompleted_displaysAllTopicCards #2587

Closed
yurilev opened this issue Jan 30, 2021 · 0 comments
Closed

Fix test testHomeActivity_allTopicsCompleted_displaysAllTopicCards #2587

yurilev opened this issue Jan 30, 2021 · 0 comments
Assignees
@deonwaju
Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@yurilev
Copy link
Contributor

yurilev commented Jan 30, 2021

testHomeActivity_allTopicsCompleted_displaysAllTopicCards() in HomeActivityTest fails when running using Espresso in an Android emulator with a tablet image, because of the bigger screen size. (All tests pass in Robolectric.)

Other similar test methods covering "topics":

  • Have 4 versions, split into portrait/landscape and mobile/tablet.
  • Also assert the number of cards (topics).

Suggested fix:

  • Similarly split test method into 4 versions, ensuring tablet tests pass for tablets, etc.
  • Consider introducing another helper for the topic card count assertion.

Originally posted by @yurilev in #2504 (comment)
@yurilev yurilev mentioned this issue Jan 30, 2021
Closed
@yurilev yurilev changed the title testHomeActivity_allTopicsCompleted_displaysAllTopicCards() fails in tablet emulator Fix test testHomeActivity_allTopicsCompleted_displaysAllTopicCards Jan 30, 2021
@Broppia Broppia added issue_type_bug Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. Z-ibt Temporary label for Ben to keep track of issues he's triaged. issue_user_developer labels Sep 15, 2022
@seanlip seanlip added bug End user-perceivable behaviors which are not desirable. and removed issue_user_developer labels Mar 29, 2023
@seanlip seanlip added the Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. label Jun 7, 2023
@adhiamboperes adhiamboperes removed the Issue: Needs Clarification Indicates that an issue needs more detail in order to be able to be acted upon. label Jan 24, 2024
@deonwaju deonwaju mentioned this issue Feb 4, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deonwaju deonwaju

Labels
bug End user-perceivable behaviors which are not desirable. Impact: Low Low perceived user impact (e.g. edge cases). Work: Medium The means to find the solution is clear, but it isn't at good-first-issue level yet. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
No milestone
Development

No branches or pull requests
6 participants
@yurilev @seanlip @BenHenning @deonwaju @adhiamboperes @Broppia