Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fragment implementation from directly xml code to better kotlin code [Blocked on #42, #163] #235

Closed
2 tasks
rt4914 opened this issue Oct 15, 2019 · 3 comments
Closed
2 tasks

Change fragment implementation from directly xml code to better kotlin code [Blocked on #42, #163] #235

rt4914 opened this issue Oct 15, 2019 · 3 comments
Assignees
@veena14cs
Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Milestone
0.2 Release Block...

Comments

@rt4914
Copy link
Contributor

rt4914 commented Oct 15, 2019 •
edited by veena14cs
Loading

In some cases xml files are using fragment tag directly to display a particular fragment.
This implementation needs to be changed and the xml should have a FrameLayout as container and kotlin files should initialize the corresponding fragment.

This change is needed in following cases for now:

  • exploration_fragment.xml
  • state_fragment.xml
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 15, 2019

@BenHenning I have added this as an issue so that we do get a lot of merge conflicts in other PRs, we can solve this once StateFragmentCard implementation is finished. Blocked on #42 #163

@rt4914 rt4914 changed the title Change fragment implementation from directly xml code to better kotlin code Change fragment implementation from directly xml code to better kotlin code [Blocked on #42, #163] Oct 15, 2019
@rt4914
Copy link
Contributor Author

rt4914 commented Oct 15, 2019

@veena14cs Assigning you state_fragment

@rt4914 rt4914 mentioned this issue Oct 15, 2019
Merged
2 tasks
@BenHenning
Copy link
Member

Seems sensible. Thanks for filing this.

@BenHenning BenHenning added Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Status: In implementation labels Oct 16, 2019
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@veena14cs veena14cs

Labels
Priority: Important This work item is really important to complete for its milestone, but it can be scoped out. Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Core Learner and Mastery flows & UI Frontend - Android
Archived in project
Milestone
0.2 Release Blockers (Prototype MR2)
Development

No branches or pull requests
3 participants
@rt4914 @BenHenning @veena14cs