-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chapter List Page Issues #2132
Comments
I would like to work on this. |
@mschanteltc Regarding the second and the third point we only need description in the active card and for the inactive card, the description should not be visible, right? The tasks we need to do on this issue:
|
Ok, I found "Matthew Goes to Bakery" screen. Do I need to blur thumbnails, like shown in the mock? |
The tasks that need to be done are:
|
I imagine I'd need a new image to blur inactive cards? |
For inactive cards, you would need the lock icon and to blur out the card's thumbnail image. Blur it by overlaying a container that is the exact color of the thumbnail's background, drop the opacity to 50%, and apply a blur. |
* Fix part of #2132 * Fix part of #2132 * Fix part of #2132 * Fix part of #2132 * Fix part of #2132 * Fix part of #2132 * Fix part of #2132 * Pass a ChapterSummary object as a prerequisite to unlock this chapter. Remove blurring thumbnails of inactive cards - this change will be done separately. * Added tests. * Added tests. * Set missingPrerequisiteChapter in setFirstChapterAsNotStarted function. * Add a UI-facing test. * Add more test coverage for a completed chapter. * Move landscape test below the portrait one. * Added long summary test + reformatting. * Formatting. * Lint * Renaming
I will be working on a second part of this issue - blurring and locking the image. |
@mschanteltc What if background is white? Wouldn't it make the lock less visible? |
@viktoriias Background won't be white in production app. It will contain an image always. |
…s of inactive cards. (#2422) * Lock and blur * Replace color/white with #FFFFFF * Add \n * Move isBlurred to LessonThumbnailImageView. * Remove unused import. * Move dependency on Glide away from from ImageLoader. * Remove unneeded line. * Refactor Transformation-related code, add KDocs. * Renaming. * Remove unused import. * Reformat. * Add Mockk test * Add Mockk test - lint * Add blurring tests. * Mock ImageLoader in StoryActivityTest. * Add delay before image loading. * Nits and improvements. * Remove unused import. * Remove unused import. * Set image resources in LessonThumbnailImageView in addition to calling GlideImageLoader. * BlurTransformation re-write. * BlurTransformation re-write. * Add TestImageLoaderModule to some tests. * Lint * Add TestImageLoaderModule to more tests. * Add TestImageLoaderModule to more tests. * Update utility/src/main/java/org/oppia/android/util/parser/BlurTransformation.kt Co-authored-by: Ben Henning <[email protected]> * Update utility/src/main/java/org/oppia/android/util/parser/BlurTransformation.kt Co-authored-by: Ben Henning <[email protected]> * TestGlideImageLoader Refactor. * Reformat. * Reformat. * Reformat. * Nits and comments. * Revert changes in landscape design. * Change BlurTransformation to return a copy instead of 'toTransform'. * Update app/src/sharedTest/java/org/oppia/android/app/story/StoryFragmentTest.kt Co-authored-by: Ben Henning <[email protected]> * Refactor TestGlideImageLoader. * Nits Co-authored-by: Ben Henning <[email protected]>
The text was updated successfully, but these errors were encountered: