Replace Language code with icon in AudioBar

[rt4914]

Currently Audio Bar in exploration has a language code, as shown below:

We should replace the language code to icon as shown below:

Reference: https://xd.adobe.com/view/e8aa4198-3940-47f9-514a-f41cc54457f6-9e9b/screen/d74f0571-471f-4ea6-a3a5-32e135253c56/

The tests in AudioFragmentTest need to be updated (see the TODOs there).

[MaskedCarrot]

Hello, can I work on this issue?

[aggarwalpulkit596]

@MaskedCarrot sure go ahead

[MaskedCarrot]

I tried creating a pr but the bot closes it every time and I can't figure out the reason for this from the documentation. Can you please help me.

[aggarwalpulkit596]

https://github.com/oppia/oppia/wiki/Contributing-code-to-Oppia#setting-things-up you have to follow the steps here first. Have you completed all of the steps mentioned here ?

[rt4914]

I tried creating a pr but the bot closes it every time and I can't figure out the reason for this from the documentation. Can you please help me.

@MaskedCarrot Thats because you haven't filled the forms on this link:
https://github.com/oppia/oppia-android/wiki#onboarding-instructions

Also, if you are fully sure that you have filled both the forms - CLA and contributor survey, then when you finish it just take screenshot and share it with us and maybe we can look into the issue. But in most cases it happens if the student does not fill all the details.

[rt4914]

Adding @seanlip and @BenHenning if further investigation is needed.

[seanlip]

@rt4914 This seems fine now, I think? I see a PR here.

[anandwana001]

@rt4914 quick question, If we are moving towards icon this means the check the current language a user has to click on the icon and check on the dialog box which language is currently selected.

Or are we going to have multiple icons which shows language translations? For example with the above icon which shows English and Japanese or may be Chinese, should we go for icons like English to Hindi and for all other translations?
Because what I think here is the icon say translating from English to Japanses and the audio is in Hindi.

[rt4914]

@rt4914 This seems fine now, I think? I see a PR here.

@seanlip Thanks. Everything is correct now.

[rt4914]

@rt4914 quick question, If we are moving towards icon this means the check the current language a user has to click on the icon and check on the dialog box which language is currently selected.

Or are we going to have multiple icons which shows language translations? For example with the above icon which shows English and Japanese or may be Chinese, should we go for icons like English to Hindi and for all other translations?
Because what I think here is the icon say translating from English to Japanses and the audio is in Hindi.

@anandwana001 What you have mentioned it actually correct but this was finalised after the user study and as per results, students are not thinking that its audio change from English to Japanese, instead its interpreted as Change Language option, which makes more sense here. Does this help?

[anandwana001]

@rt4914 quick question, If we are moving towards icon this means the check the current language a user has to click on the icon and check on the dialog box which language is currently selected.
Or are we going to have multiple icons which shows language translations? For example with the above icon which shows English and Japanese or may be Chinese, should we go for icons like English to Hindi and for all other translations?
Because what I think here is the icon say translating from English to Japanses and the audio is in Hindi.

@anandwana001 What you have mentioned it actually correct but this was finalised after the user study and as per results, students are not thinking that its audio change from English to Japanese, instead its interpreted as Change Language option, which makes more sense here. Does this help?

Yes, sounds good to me.

[BenHenning]

@MaskedCarrot are you still working on this issue?

[MaskedCarrot]

@BenHenning I think this is blocked because audioFragmentTest are failing.

[anandwana001]

@BenHenning I think this is blocked because audioFragmentTest are failing.

It's merged. You can continue the work, if you need any help in testing part let's connect over Gitter.