Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for parameters in the exploration player #179

Closed
BenHenning opened this issue Sep 25, 2019 · 5 comments · Fixed by #4928
Closed

Add support for parameters in the exploration player #179

BenHenning opened this issue Sep 25, 2019 · 5 comments · Fixed by #4928
Assignees
@seanlip
Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.

Comments

@BenHenning
Copy link
Member

For parity with Oppia web, we need support for parameters in the exploration player.
@BenHenning BenHenning added this to the Minimal Viable Product milestone Sep 25, 2019
@seanlip
Copy link
Member

seanlip commented Sep 25, 2019 via email

@BenHenning BenHenning modified the milestones: Minimal Viable Product, Global Availability Jun 23, 2020
@Broppia Broppia added issue_type_infrastructure Impact: Low Low perceived user impact (e.g. edge cases). labels Jul 29, 2022
@BenHenning BenHenning added the Z-ibt Temporary label for Ben to keep track of issues he's triaged. label Sep 16, 2022
@BenHenning
Copy link
Member Author

Per the comment above, closing this since it's unlikely that we'll actually need it (and haven't so far). Plus, once the new proto APIs are introduced in Oppia web to facilitate downloads we'll be able to explicitly prohibit allowing the client to have access to explorations with parameters.

@BenHenning BenHenning closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2022
Repository owner moved this from Needs Triage to Done in [Team] Developer Workflow & Infrastructure - Android Sep 16, 2022
@github-actions github-actions bot reopened this Sep 16, 2022
@github-actions
Copy link

The issue is reopened because of the following unresolved TODOs:

oppia-android/domain/src/main/java/org/oppia/android/domain/exploration/ExplorationProgressController.kt

Line 111 in f99fa1d

// TODO(#179): Add support for parameters.

@BenHenning
Copy link
Member Author

The AI here is to remove the TODO from code so that the issue can be closed.

@BenHenning BenHenning removed this from the Global Availability milestone Sep 16, 2022
@seanlip seanlip added good first issue This item is good for new contributors to make their pull request. enhancement End user-perceivable enhancements. and removed issue_type_infrastructure labels Mar 28, 2023
@seanlip
Copy link
Member

seanlip commented Mar 28, 2023

Note to contributors: this is an extremely easy good first issue! It just involves removing the TODO.

@seanlip seanlip self-assigned this Mar 29, 2023
@seanlip seanlip mentioned this issue Mar 29, 2023
Merged
6 tasks
BenHenning pushed a commit that referenced this issue Mar 30, 2023
@seanlip
Fix #248, #501, #179, #762, #207: Remove obsolete TODOs. (#4928)
1c95dd3 
## Explanation

Fixes #248
Fixes #501
Fixes #179
Fixes #762
Fixes #207

This PR removes some obsolete TODOs so that the corresponding issues on
GitHub can be properly closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Uticodes pushed a commit to Uticodes/oppia-android that referenced this issue Apr 4, 2023
@seanlip @Uticodes
Fix oppia#248, oppia#501, oppia#179, oppia#762, oppia#207: Remove obs…
9a747f5 
…olete TODOs. (oppia#4928)

## Explanation

Fixes oppia#248
Fixes oppia#501
Fixes oppia#179
Fixes oppia#762
Fixes oppia#207

This PR removes some obsolete TODOs so that the corresponding issues on
GitHub can be properly closed.

## Essential Checklist
<!-- Please tick the relevant boxes by putting an "x" in them. -->
- [x] The PR title and explanation each start with "Fix #bugnum: " (If
this PR fixes part of an issue, prefix the title with "Fix part of
#bugnum: ...".)
- [x] Any changes to
[scripts/assets](https://github.com/oppia/oppia-android/tree/develop/scripts/assets)
files have their rationale included in the PR explanation.
- [x] The PR follows the [style
guide](https://github.com/oppia/oppia-android/wiki/Coding-style-guide).
- [x] The PR does not contain any unnecessary code changes from Android
Studio
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#undo-unnecessary-changes)).
- [x] The PR is made from a branch that's **not** called "develop" and
is up-to-date with "develop".
- [x] The PR is **assigned** to the appropriate reviewers
([reference](https://github.com/oppia/oppia-android/wiki/Guidance-on-submitting-a-PR#clarification-regarding-assignees-and-reviewers-section)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@seanlip seanlip

Labels
enhancement End user-perceivable enhancements. good first issue This item is good for new contributors to make their pull request. Impact: Low Low perceived user impact (e.g. edge cases). Z-ibt Temporary label for Ben to keep track of issues he's triaged.
Projects
[Team] Developer Workflow & Infrastructure - Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #248, #501, #179, #762, #207: Remove obsolete TODOs. oppia/oppia-android
3 participants
@seanlip @BenHenning @Broppia