Consume 0.20.0 version of operator framework api #6639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kevinrizza <[email protected]>
everettraven
approved these changes
Dec 13, 2023
|
@everettraven looks like the linter is failing because of https://staticcheck.dev/docs/checks/#SA1019 against the old validator. That's valid, because the old validator is deprecated, but do you know if there's a way to allow it anyway? Or is it expected that we remove anything that is deprecated immediately? This will be a backwards incompatible update if we just remove the validator. |
| desc: "OperatorHub.io categories metadata validation. ", | ||
| }, | ||
| { | ||
| Validator: apivalidation.OperatorHubValidator, |
There was a problem hiding this comment.
I think doing the following will silence the lint error since this is intentional:
Suggested change
| Validator: apivalidation.OperatorHubValidator, | |
| Validator: apivalidation.OperatorHubValidator // nolint: staticcheck, |
Signed-off-by: kevinrizza <[email protected]>
kevinrizza
force-pushed
the
update-api-to-1.20
branch
from
2b68396 to
dac61a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request updates the operator-framework api dependency to 0.20.0.
As part of that consumption, this updates the
operator-sdk bundle validatecommand to consume the new hierarchy of optional validators, given the deprecation of the optionaloperatorhubvalidator. See operator-framework/api#304 for more info.