Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate Category and Capability Validation #304

Conversation

kevinrizza
Copy link
Member

@kevinrizza kevinrizza commented Nov 1, 2023

This commit removes the default set of category and capability validation as a part of the operatorhubio validator.

As we have a mechanism for custom category validation, and there is significantly more churn on that specific validation, this commit separates the default operatorhubio validator from a distinct default categories validator. This allows users that want to continue to use the default set of categories to still do so, and if there are custom categories they would like to include they are free to use the dynamic categories validation option instead.

This commit also does the same separation for capability validation. There is no implementation of custom capability validation (as there is less churn and no explicit need for that yet) -- adding custom capability validation should be trivial in a future commit.

This commit accomplishes this by deprecating the existing validator and creating a v2 version of the operatorhubio validator.

Additionally, this commit adds 'Observability' to the category list.

Copy link

openshift-ci bot commented Nov 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevinrizza

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 1, 2023
Copy link

codecov bot commented Nov 1, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (d52e6b2) 41.99% compared to head (e2aeec7) 42.64%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #304      +/-   ##
==========================================
+ Coverage   41.99%   42.64%   +0.64%     
==========================================
  Files          39       42       +3     
  Lines        3512     3583      +71     
==========================================
+ Hits         1475     1528      +53     
- Misses       1891     1903      +12     
- Partials      146      152       +6     
Files Coverage Δ
pkg/validation/internal/operatorhub.go 81.44% <100.00%> (+3.37%) ⬆️
pkg/validation/internal/standardcapabilities.go 78.94% <78.94%> (ø)
pkg/validation/internal/standardcategories.go 70.96% <70.96%> (ø)
pkg/validation/internal/operatorhubv2.go 68.42% <68.42%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This commit removes the default set of category and capability validation
as a part of the operatorhubio validator.

As we have a mechanism for custom category validation, and there is
significantly more churn on that specific validation, this commit
separates the default operatorhubio validator from a distinct default
categories validator. This allows users that want to continue to use the
default set of categories to still do so, and if there are custom
categories they would like to include they are free to use the dynamic
categories validation option instead.

This commit also does the same separation for capability validation.
There is no implementation of custom capability validation (as there is
less churn and no explicit need for that yet) -- adding custom
capability validation should be trivial in a future commit.

This commit accomplishes this by deprecating the existing validator and
creating a v2 version of the operatorhubio validator.

Additionally, this commit adds 'Observability' to the category list.
@kevinrizza kevinrizza force-pushed the separate-category-validator branch from 22eb931 to e2aeec7 Compare November 2, 2023 13:58
@kevinrizza kevinrizza changed the title Separate Category Validation Separate Category and Capability Validation Nov 2, 2023
@joelanford
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 2, 2023
@openshift-ci openshift-ci bot merged commit 73a5934 into operator-framework:master Nov 2, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants