-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump versions for k8s 1.24 #5843
Bump versions for k8s 1.24 #5843
Conversation
Signed-off-by: Austin Macdonald <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 🥇
Some nits;
a) we need to fix the changelog and ensure that it has only what impacts the end-users
also, changes in the scaffolds need migration steps
b) I do not think that we need/should change the Leader election here. We need to check how that will affect endusers, can we do a PR only for that?
I'll make some changes to the changelog to reflect this.
Unfortunately I don't think we can do it in a separate PR as client-go/leaderelection/resourcelock that comes with v0.24.0 forces the change. My understanding is that this change should be a safe step in the migration to As an extra note, our e2e tests have passed with the changes as well. |
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
/hold still a WIP |
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@camilamacedo86 Thanks so much for all the help with the changelog! |
/hold We need to bump the OPM version in the Makefile scaffolds to be 1.23.0 |
Signed-off-by: Bryce Palmer <[email protected]>
Also fixes #5854 |
Signed-off-by: Bryce Palmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, dont hold bc of this review
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (I cant approve because I am the OP)
the sanity/docs job is failing due to 1 broken link: https://v1-15-x.sdk.operatorframework.io/ which does work. This is 100% just a flake, I feel comfortable doing an admin merge to keep this moving.
/lgtm |
/approved Great work !!! |
Passing off to @everettraven since I'll be out today. I will be on slack if there are any questions.
If the tests don't pass we will make this a feature branch, but for the sake of go.mod merge conflicts, lets try to avoid that if possible. IMO an admin-merge could be appropriate if the tests will be fixed quickly.
Signed-off-by: Austin Macdonald [email protected]
Closes: #5833