-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(chore): bump k8s to 1.24 #964
(chore): bump k8s to 1.24 #964
Conversation
Codecov Report
@@ Coverage Diff @@
## master #964 +/- ##
==========================================
- Coverage 52.48% 52.47% -0.02%
==========================================
Files 103 103
Lines 9240 9240
==========================================
- Hits 4850 4849 -1
- Misses 3468 3469 +1
Partials 922 922
Continue to review full report at Codecov.
|
How hard would it be to bump the CRD versions from v1beta1 to v1? v1beta1 CRDs are no longer supported (since k8s 1.22), so it seems like those should be bumped at some point. It seems like this could be done in a follow-up since the tests seem to have all passed. |
@joelanford I don't think it should be to difficult to do that, but can't say for sure. I agree that this would be a good follow up item. May even be able to get away with an update from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dinhxuanvu, everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
02e83b9
to
02ee178
Compare
@everettraven Would you mind rebasing this PR? |
@dinhxuanvu just gave it a shot (still learning how to rebase). Let me know if it needs anything else. Also noticed the e2e test failed while trying to install podman. the go-apidiff is also an expected failure due to some changes in the |
I'm trying to look into this podman installation problem. go-apidiff is expected to fail here so no worries about that. |
The podman installation issue seems to be a known issue that is pending: containers/podman#14278 (comment) |
|
@dinhxuanvu is there anything else that needs to be done to get this merged? |
/lgtm |
Description of the change:
Made changes to bump k8s dependencies to support k8s 1.24.
Changes:
vendor
directory from runninggo mod vendor
spec
to have thepreserveUnknownFields: false
value.preserveUnknownFields
field being automatically set totrue
. I believe this has to do with the v1beta1 CRDs being converted to v1 since v1beta1 is no longer supported for CRDs (more info: https://kubernetes.io/docs/tasks/extend-kubernetes/custom-resources/custom-resource-definitions/#field-pruning). If this should not be done I am happy to try and find a different solution, but this seemed to resolve the issues.CRD etcdclusters.etcd.database.coreos.com/v1beta2 is present in bundle "etcdoperator.v0.9.4" but not defined in CSV
to show up as an error. I found that the following shows that it should be a warning and not an error:operator-registry/pkg/lib/validation/bundle.go
Lines 63 to 66 in 1436816
Motivation for the change:
Begin supporting k8s 1.24
Reviewer Checklist
/docs