test(csv): use mock-ext-server for owned apiservice e2e test #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/L
njhale
commented
Dec 3, 2018
| @@ -129,6 +130,9 @@ func (a *Operator) checkAPIServiceResources(csv *v1alpha1.ClusterServiceVersion, | |||
|
|
|||
| // Ensure the Deployment's ServiceAccount exists | |||
| serviceAccountName := deployment.Spec.Template.Spec.ServiceAccountName | |||
| if serviceAccountName == "" { | |||
There was a problem hiding this comment.
Use default if not defined by the template.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: njhale The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
ecordell
approved these changes
Dec 3, 2018
ecordell
pushed a commit
to ecordell/operator-lifecycle-manager
that referenced
this pull request
Mar 8, 2019
test(csv): use mock-ext-server for owned apiservice e2e test
njhale
added
the
kind/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Uses the mock-extension-apiserver for all e2e tests involving an owned APIService.
Supersedes #579