feat(apiservices): implement apiservice mock server #579
Conversation
openshift-ci-robot
added
the
size/XXL
|
/assign @jpeeler |
njhale
force-pushed
the
mock-ext-server
branch
from
8f61839 to
8fd31c3
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alecmerdler The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest |
1 similar comment
|
/retest |
|
/test e2e-aws |
3 similar comments
|
/test e2e-aws |
|
/test e2e-aws |
|
/test e2e-aws |
| package v1alpha1 | ||
|
|
||
| import ( | ||
| // "k8s.io/apimachinery/pkg/runtime" |
There was a problem hiding this comment.
Thought I had already removed this. Will do soon.
upstream.Dockerfile
Outdated
| @@ -14,6 +14,7 @@ WORKDIR / | |||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/olm /bin/olm | |||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/catalog /bin/catalog | |||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/package-server /bin/package-server | |||
| COPY --from=builder /go/src/github.com/operator-framework/operator-lifecycle-manager/bin/mock-ext-server /bin/mock-ext-server | |||
There was a problem hiding this comment.
do we want this in non-test containers?
There was a problem hiding this comment.
Yes you are correct. This should only be in test containers.
njhale
force-pushed
the
mock-ext-server
branch
from
8fd31c3 to
19675f4
Compare
|
New changes are detected. LGTM label has been removed. |
|
@njhale: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@njhale: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@njhale: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@njhale: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Superseded by #593 |
Description
mock-ext-server) which can be configured to register mock GVKs with discovery.mock-ext-serverinTestCreateCSVWithOwnedAPIServicee2e test.defaultServiceAccount if none are listed in a CSVs owned APIService deployment spec.goimportson project.