Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove Makefile vertical code alignment #827

Merged
merged 1 commit into from
May 3, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented May 3, 2024

Description

I would prefer if we could avoid formatting like this as it is hard to maintain this style. This also leads to larger diffs: for example, here I wanted to only remove one line but I had to change another for it to not look weird.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
Copy link

netlify bot commented May 3, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit d4884ec
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6634cdc7a38523000864b5a2
😎 Deploy Preview https://deploy-preview-827--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola marked this pull request as ready for review May 3, 2024 09:42
@m1kola m1kola requested a review from a team as a code owner May 3, 2024 09:42
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@m1kola m1kola requested a review from joelanford May 3, 2024 09:42
Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.63%. Comparing base (a13a9d8) to head (d4884ec).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #827   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files          16       16           
  Lines        1315     1315           
=======================================
  Hits          850      850           
  Misses        403      403           
  Partials       62       62           
Flag Coverage Δ
e2e 41.90% <ø> (ø)
unit 57.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelanford
Copy link
Member

Oh. Does the vertical alignment mess something up?

@m1kola
Copy link
Member Author

m1kola commented May 3, 2024

Oh. Does the vertical alignment mess something up?

Technically - I don't think so. Just suggesting to remove it because it will become visually messy soon since we do not have automation like go fmt for Makefile to maintain it. Also this leads to bigger diffs: if you change one line and it changes the alignment - you have to change all the neighbouring lines. Or like in this I just wanted to remove one line and had to make a change to another.

perdasilva
perdasilva previously approved these changes May 3, 2024
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@m1kola
Copy link
Member Author

m1kola commented May 3, 2024

Rebased to fix conflict with #798

@joelanford
Copy link
Member

Good point!

@m1kola m1kola added this pull request to the merge queue May 3, 2024
Merged via the queue into operator-framework:main with commit fadfe36 May 3, 2024
16 checks passed
@m1kola m1kola deleted the undo_formatting branch May 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants