Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Remove duplicated requirements.txt #798

Merged
merged 1 commit into from
May 3, 2024

Conversation

m1kola
Copy link
Member

@m1kola m1kola commented Apr 29, 2024

Description

We had two requirements.txt: one for local builds and one for Netlify. This PR removes one of them and makes both setups use the same file.

Reviewer Checklist

  • API Go Documentation
  • Tests: Unit Tests (and E2E Tests, if appropriate)
  • Comprehensive Commit Messages
  • Links to related GitHub Issue(s)

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 29, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 29, 2024
Copy link

netlify bot commented Apr 29, 2024

Deploy Preview for olmv1 ready!

Name Link
🔨 Latest commit 2078b56
🔍 Latest deploy log https://app.netlify.com/sites/olmv1/deploys/6634a8c5eb67fd000828ceda
😎 Deploy Preview https://deploy-preview-798--olmv1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@m1kola m1kola force-pushed the netlify_cleanup branch 2 times, most recently from d4b66d5 to f19017e Compare May 2, 2024 16:02
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
@m1kola m1kola marked this pull request as ready for review May 2, 2024 16:05
@m1kola m1kola requested a review from a team as a code owner May 2, 2024 16:05
Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.63%. Comparing base (5985cce) to head (2078b56).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #798   +/-   ##
=======================================
  Coverage   64.63%   64.63%           
=======================================
  Files          16       16           
  Lines        1315     1315           
=======================================
  Hits          850      850           
  Misses        403      403           
  Partials       62       62           
Flag Coverage Δ
e2e 41.90% <ø> (ø)
unit 57.71% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

everettraven
everettraven previously approved these changes May 2, 2024
@everettraven everettraven added this pull request to the merge queue May 2, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 2, 2024
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 2, 2024
Signed-off-by: Mikalai Radchuk <[email protected]>
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2024
@m1kola m1kola removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@m1kola
Copy link
Member Author

m1kola commented May 3, 2024

Rebased to resolve conflict in Makefile and manually removed do-not-merge/work-in-progress label - it looks like bot missed an event when I converted the PR from draft to ready for review.

@m1kola m1kola enabled auto-merge May 3, 2024 09:14
Copy link
Contributor

@perdasilva perdasilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm nice one!

@m1kola m1kola added this pull request to the merge queue May 3, 2024
Merged via the queue into operator-framework:main with commit a13a9d8 May 3, 2024
17 checks passed
@m1kola m1kola deleted the netlify_cleanup branch May 3, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants