bump dependencies to support k8s 1.24 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
Signed-off-by: Bryce Palmer <[email protected]>
varshaprasad96
requested changes
Jun 7, 2022
| @@ -45,7 +45,7 @@ type MemcachedReconciler struct { | |||
| // the user. | |||
| // | |||
| // For more details, check Reconcile and its Result here: | |||
| // - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.11.2/pkg/reconcile | |||
| // - https://pkg.go.dev/sigs.k8s.io/controller-runtime@v0.12.1/pkg/reconcile | |||
There was a problem hiding this comment.
We may have to regenerate the testdata again. I'm curious because the deps in the scaffolding aren't updated yet (
helm-operator-plugins/testdata/hybrid/memcached-operator/go.mod
Lines 9 to 10 in 5b29693
There was a problem hiding this comment.
Hmm, I will take a look into this. Thanks for pointing this out @varshaprasad96
There was a problem hiding this comment.
So it looks like when attempting to scaffold the testdata that it tries to pull the latest helm-plugins release which does not support k8s 1.24. Once we get this merged and a new release created I can create a follow-up PR to fix the testdata.
Pull Request Test Coverage Report for Build 2455687789
💛 - Coveralls |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps dependencies and makes necessary modifications to support k8s 1.24