Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bin. annotation http.path for every request #93

Closed
wants to merge 1 commit into from
Closed

Add bin. annotation http.path for every request #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/zipkin-tracer/rack/zipkin-tracer.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def annotate_plugin(env, status, response_headers, response_body)

def trace!(span, zipkin_env, &block)
# if called by a service, the caller already added the information
trace_request_information(span, zipkin_env.env) unless zipkin_env.called_with_zipkin_headers?
trace_request_information(span, zipkin_env.env)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in a shared span (which is the current model), this will duplicate the entry (once for the client and again for the server). For many, making this change will clutter the span view and also add data with no value unless there's some proxy going on. I'm working in the java (Brave) codebase to make something like this opt-in vs required for all users.

when/if we move to a single-host model, I'd agree with this change regardless, but for now I do think it will clutter most people's span detail screen.
openzipkin/zipkin#939 (comment)

span.record(Trace::Annotation::SERVER_RECV)
span.record('whitelisted') if zipkin_env.force_sample?
status, headers, body = yield
Expand Down