Add bin. annotation http.path for every request #93
Conversation
|
@adriancole knows more about all the other implementations out there. |
| @@ -53,7 +53,7 @@ def annotate_plugin(env, status, response_headers, response_body) | |||
|
|
|||
| def trace!(span, zipkin_env, &block) | |||
| # if called by a service, the caller already added the information | |||
| trace_request_information(span, zipkin_env.env) unless zipkin_env.called_with_zipkin_headers? | |||
There was a problem hiding this comment.
in a shared span (which is the current model), this will duplicate the entry (once for the client and again for the server). For many, making this change will clutter the span view and also add data with no value unless there's some proxy going on. I'm working in the java (Brave) codebase to make something like this opt-in vs required for all users.
when/if we move to a single-host model, I'd agree with this change regardless, but for now I do think it will clutter most people's span detail screen.
openzipkin/zipkin#939 (comment)
|
@jcarres-mdsol @adriancole thanks for feedback. I'm closing it. |
Even though incoming request comes from a traced service it is not guaranteed that
http.path|url|uriwas added at a client side.@jcarres-mdsol could you please review?