Add support for RemoteEndpoint in transport/client.

[dengliming]

for #108

@jcchavezs Can you help to review these changes?

[coveralls]

Coverage increased (+0.2%) to 61.144% when pulling a4d4e71 on dengliming:f_endpoint into c1d1eb5 on openzipkin:master.

[jcchavezs]

While my hunch is that in 97% of the cases this will only be used for passing the service name, I think it is also good to keep consistency with the local endpoint and also to keep the API surface tick by accepting the Endpoint instead of just the service name (plus the endpoint as we should also accept that too if we go for service name first). Any thoughts @basvanbeek? tir. 11. aug. 2020, 17:57 skrev Coveralls <[email protected]>:

…

[image: Coverage Status] <https://coveralls.io/builds/32680438> Coverage increased (+0.1%) to 61.072% when pulling *b00ba74 <b00ba74> on dengliming:f_endpoint* into *c1d1eb5 <c1d1eb5> on openzipkin:master*. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#170 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAV2BQDBKSSOAZ7E2O3SAFS7TANCNFSM4P3GAIUQ> .

[basvanbeek]

Agree with @jcchavezs. We should allow for remote endpoint as functional option instead of only the service name.

[dengliming]

@jcchavezs Hey~ just make sure I understand exactly what you mean. Do you mean like that?

type Client struct {
	*http.Client
	tracer            *zipkin.Tracer
	httpTrace         bool
	defaultTags       map[string]string
	transportOptions  []TransportOption
	remoteEndpoint *model.Endpoint
}

func WithRemoteEndpoint(remoteEndpoint *model.Endpoint) ClientOption {
	return func(c *Client) {
		c.remoteEndpoint = remoteEndpoint
	}
}

[jcchavezs]

Yes, exactly that. ons. 12. aug. 2020, 15:38 skrev dengliming <[email protected]>:

…

@jcchavezs <https://github.com/jcchavezs> Hey~ just make sure I understand exactly what you mean. Do you mean like that? type Client struct { *http.Client tracer *zipkin.Tracer httpTrace bool defaultTags map[string]string transportOptions []TransportOption remoteEndpoint *model.Endpoint } func WithRemoteEndpoint(remoteEndpoint *model.Endpoint) ClientOption { return func(c *Client) { c.remoteEndpoint = remoteEndpoint } } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#170 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAXOYAT53TZKL6ELBZ335QLSAKLOLANCNFSM4P3GAIUQ> .

[dengliming]

@jcchavezs Can you review again? Thanks.

[jcchavezs]

Thanks a lot!