Don't include the http.status_code when 2xx in server. (#167)

openzipkin · Aug 11, 2020 · c1d1eb5 · c1d1eb5
1 parent b483259
commit c1d1eb5
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/middleware/http/server.go b/middleware/http/server.go
@@ -145,10 +145,12 @@ func (h handler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 	defer func() {
 		code := ri.getStatusCode()
 		sCode := strconv.Itoa(code)
-		if code > 399 {
-			h.errHandler(sp, nil, code)
+		if code < 200 || code > 299 {
+			zipkin.TagHTTPStatusCode.Set(sp, sCode)
+			if code > 399 {
+				h.errHandler(sp, nil, code)
+			}
 		}
-		zipkin.TagHTTPStatusCode.Set(sp, sCode)
 		if h.tagResponseSize && atomic.LoadUint64(&ri.size) > 0 {
 			zipkin.TagHTTPResponseSize.Set(sp, ri.getResponseSize())
 		}

diff --git a/middleware/http/server_test.go b/middleware/http/server_test.go
@@ -179,6 +179,7 @@ func TestHTTPDefaultSpanName(t *testing.T) {
 		httpRecorder = httptest.NewRecorder()
 		requestBuf   = bytes.NewBufferString("incoming data")
 		methodType   = "POST"
+		code         = ""
 	)
 
 	request, err := http.NewRequest(methodType, "/test", requestBuf)
@@ -203,6 +204,10 @@ func TestHTTPDefaultSpanName(t *testing.T) {
 	if want, have := methodType, span.Name; want != have {
 		t.Errorf("Expected span name %s, got %s", want, have)
 	}
+
+	if want, have := code, span.Tags["http.status_code"]; want != have {
+		t.Errorf("Expected span status code %s, got %s", want, have)
+	}
 }
 
 func TestHTTPRequestSampler(t *testing.T) {