ci: checks markdown for bad links #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
force-pushed
the
check-links
branch
from
a47aa97 to
cedc73f
Compare
|
ok if folks are keen on this, I can propagate to the other repos same way. |
added 2 commits
January 13, 2024 20:27
Signed-off-by: Adrian Cole <[email protected]>
Signed-off-by: Adrian Cole <[email protected]>
reta
approved these changes
Jan 13, 2024
Signed-off-by: Adrian Cole <[email protected]>
| --- | ||
| name: test_markdown | ||
|
|
||
| on: # yamllint disable-line rule:truthy |
There was a problem hiding this comment.
TIL why on: was making truthy warnings.. here are some details @openzipkin/devops-tooling adrienverge/yamllint#430
now, finally we have one workflow that has no lint output
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Jan 14, 2024
We should quote any example links and only add links for things that are always up, or will be up due following instructions. For example, we should add exceptions for localhost services that run in result of test commands for zipkin or the UI. See openzipkin/zipkin-gcp#212 for the first impl of this. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Jan 14, 2024
We should quote any example links and only add links for things that are always up, or will be up due following instructions. For example, we should add exceptions for localhost services that run in result of test commands for zipkin or the UI. See openzipkin/zipkin-gcp#212 for the first impl of this. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
pushed a commit
to openzipkin/zipkin
that referenced
this pull request
Jan 14, 2024
We should quote any example links and only add links for things that are always up, or will be up due following instructions. For example, we should add exceptions for localhost services that run in result of test commands for zipkin or the UI. See openzipkin/zipkin-gcp#212 for the first impl of this. Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
pushed a commit
to openzipkin/zipkin-dependencies
that referenced
this pull request
Apr 16, 2024
originally added here openzipkin/zipkin-gcp#212 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
pushed a commit
to openzipkin/zipkin-dependencies
that referenced
this pull request
May 26, 2024
originally added here openzipkin/zipkin-gcp#212 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
pushed a commit
to openzipkin/zipkin-dependencies
that referenced
this pull request
May 26, 2024
originally added here openzipkin/zipkin-gcp#212 Signed-off-by: Adrian Cole <[email protected]>
codefromthecrypt
added a commit
to openzipkin/zipkin-dependencies
that referenced
this pull request
May 26, 2024
originally added here openzipkin/zipkin-gcp#212 Signed-off-by: Adrian Cole <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
want to automate this so we don't have users complain into the void #198